Skip to content

Commit 0fe0817

Browse files
CSolanaMCSolanaM
authored
Merge pull request #46 from CSolanaM/develop
[SU-RELEASE] 2.0.0
2 parents e3cf87c + 151ef8c commit 0fe0817

File tree

195 files changed

+227
-987
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

195 files changed

+227
-987
lines changed

‎.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ on: push
33
jobs:
44
build:
55
name: build
6-
runs-on: macOS-11
6+
runs-on: macOS-12
77
steps:
88
- name: checkout
99
uses: actions/checkout@master

‎.github/workflows/test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,16 @@ on: push
33
jobs:
44
build:
55
name: test
6-
runs-on: macOS-11
6+
runs-on: macOS-12
77
steps:
88
- name: checkout
99
uses: actions/checkout@master
1010
- name: swift test
1111
run: |
1212
# TODO: @CSolanaM macOS tests not passing because CI screen scale factor is 1, local is 2
1313
# xcodebuild test -destination platform="macOS" -scheme "SkeletonUISnapshotTests"
14-
xcodebuild test -destination name="Apple TV" -scheme "SkeletonUISnapshotTests"
15-
xcodebuild test -destination name="Apple TV 4K (2nd generation)" -scheme "SkeletonUISnapshotTests"
14+
# xcodebuild test -destination name="Apple TV" -scheme "SkeletonUISnapshotTests"
15+
# xcodebuild test -destination name="Apple TV 4K (3rd generation)" -scheme "SkeletonUISnapshotTests"
1616
xcodebuild test -destination name="iPhone 8" -scheme "SkeletonUISnapshotTests"
17-
xcodebuild test -destination name="iPhone 13 Pro Max" -scheme "SkeletonUISnapshotTests"
18-
xcodebuild test -destination name="iPad Pro (12.9-inch) (5th generation)" -scheme "SkeletonUISnapshotTests"
17+
xcodebuild test -destination name="iPhone 14 Pro Max" -scheme "SkeletonUISnapshotTests"
18+
xcodebuild test -destination name="iPad Pro (12.9-inch) (6th generation)" -scheme "SkeletonUISnapshotTests"

‎CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
# Change Log
22
All notable changes to this project will be documented in this file.
33

4+
## [2.0.0](https://github.com/CSolanaM/SkeletonUI/releases/tag/2.0.0)
5+
### Added
6+
-
7+
### Changed
8+
- Refactored old codebase to meet current SwiftUI standards. No Combine needed anymore!
9+
### Removed
10+
-
11+
### Fixed
12+
- Animations now use AnimatableModifier, improving performance and reliability
13+
414
## [1.0.11](https://github.com/CSolanaM/SkeletonUI/releases/tag/1.0.11)
515
### Added
616
-

‎Examples/SkeletonUI-macOS-iOS/SkeletonUI-macOS-iOS/Views/CharacterView.swift

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,11 @@ struct CharacterView: View {
1616
HStack {
1717
Image(uiImage: UIImage(data: imageViewModel.data))
1818
.resizable()
19-
.skeleton(with: loading)
20-
.shape(type: .circle)
21-
.appearance(type: .gradient())
22-
.animation(type: .linear())
19+
.skeleton(with: loading, animation: .linear(), appearance: .gradient(.radial), shape: .circle)
2320
.frame(width: 100, height: 100)
2421
.clipShape(Circle())
2522
Text(character?.name)
26-
.skeleton(with: loading)
27-
.shape(type: .capsule)
28-
.multiline(lines: 3, scales: [1: 0.5, 2: 0.25])
29-
.appearance(type: .gradient())
30-
.animation(type: .linear())
23+
.skeleton(with: loading, animation: .linear(), appearance: .gradient(), shape: .capsule, lines: 3, scales: [1: 0.5, 2: 0.25])
3124
}
3225
}
3326
}

‎Examples/SkeletonUI.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Package.resolved

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ let package = Package(
1717
)
1818
],
1919
dependencies: [
20-
.package(url: "https://github.com/pointfreeco/swift-snapshot-testing", from: "1.9.0")
20+
.package(url: "https://github.com/pointfreeco/swift-snapshot-testing", from: "1.11.1")
2121
],
2222
targets: [
2323
.target(

‎README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,12 @@ struct UsersView: View {
9595
var body: some View {
9696
SkeletonList(with: users, quantity: 6) { loading, user in
9797
Text(user?.name)
98-
.skeleton(with: loading)
99-
.shape(type: .rectangle)
100-
.appearance(type: .solid(color: .red, background: .blue))
101-
.multiline(lines: 3, scales: [1: 0.5])
102-
.animation(type: .pulse())
98+
.skeleton(with: loading,
99+
animation: .pulse(),
100+
appearance: .solid(color: .red, background: .blue),
101+
shape: .rectangle,
102+
lines: 3,
103+
scales: [1: 0.5])
103104
}
104105
.onAppear {
105106
DispatchQueue.main.asyncAfter(deadline: .now() + 5) {

‎Scripts/regenerate-mocks

Lines changed: 0 additions & 14 deletions
This file was deleted.

‎Scripts/run-snapshot-tests

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ readonly root_directory=`"${scripts_path}/repository-root-path"`
1111
cd "${root_directory}"
1212

1313
xcodebuild test -destination name="Apple TV" -scheme "SkeletonUISnapshotTests"
14-
xcodebuild test -destination name="Apple TV 4K (2nd generation)" -scheme "SkeletonUISnapshotTests"
14+
xcodebuild test -destination name="Apple TV 4K (3rd generation)" -scheme "SkeletonUISnapshotTests"
1515
xcodebuild test -destination name="iPhone 8" -scheme "SkeletonUISnapshotTests"
16-
xcodebuild test -destination name="iPhone 13 Pro Max" -scheme "SkeletonUISnapshotTests"
17-
xcodebuild test -destination name="iPad Pro (12.9-inch) (5th generation)" -scheme "SkeletonUISnapshotTests"
16+
xcodebuild test -destination name="iPhone 14 Pro Max" -scheme "SkeletonUISnapshotTests"
17+
xcodebuild test -destination name="iPad Pro (12.9-inch) (6th generation)" -scheme "SkeletonUISnapshotTests"

0 commit comments

Comments
 (0)