Make datetime properties timezone-aware

bgilbert · bgilbert · commit 30b509ab64ba · 2014-05-01T15:28:29.000-04:00
diff --git a/github3/models.py b/github3/models.py
@@ -12,6 +12,7 @@
 from requests.compat import urlparse, is_py2
 from github3.decorators import requires_auth
 from github3.session import GitHubSession
+from github3.utils import UTC
 from datetime import datetime
 from logging import getLogger
 
@@ -36,9 +37,12 @@ def to_json(self):
         return self._json_data
 
     def _strptime(self, time_str):
-        """Converts an ISO 8601 formatted string into a datetime object."""
+        """Convert an ISO 8601 formatted string in UTC into a
+        timezone-aware datetime object."""
         if time_str:
-            return datetime.strptime(time_str, __timeformat__)
+            # Parse UTC string into naive datetime, then add timezone
+            dt = datetime.strptime(time_str, __timeformat__)
+            return dt.replace(tzinfo=UTC())
         return None
 
     def _repr(self):
diff --git a/github3/utils.py b/github3/utils.py
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 from collections import Callable
-from datetime import datetime
+from datetime import datetime, timedelta, tzinfo
 from requests.compat import basestring
 import re
 
@@ -30,6 +30,25 @@ def timestamp_parameter(timestamp, allow_none=True):
     raise ValueError("Cannot accept type %s for timestamp" % type(timestamp))
 
 
+class UTC(tzinfo):
+    """Yet another UTC reimplementation, to avoid a dependency on pytz or
+    dateutil."""
+
+    _ZERO = timedelta(0)
+
+    def __repr__(self):
+        return 'UTC()'
+
+    def dst(self, dt):
+        return self._ZERO
+
+    def tzname(self, dt):
+        return 'UTC'
+
+    def utcoffset(self, dt):
+        return self._ZERO
+
+
 def stream_response_to_file(response, path=None):
     pre_opened = False
     fd = None
diff --git a/tests/test_models.py b/tests/test_models.py
@@ -36,6 +36,12 @@ def test_boolean(self):
 
         self.assertRaises(github3.GitHubError, self.g._boolean, r, 200, 404)
 
+    def test_strptime(self):
+        dt = self.g._strptime('2013-06-18T19:53:04Z')
+        assert dt.tzname() == 'UTC'
+        assert dt.dst().total_seconds() == 0
+        assert dt.utcoffset().total_seconds() == 0
+
 
 class TestGitHubError(TestCase):
     def __init__(self, methodName='runTest'):
