Skip to content

Implement orbital precession #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pedro-fixingstuff
Copy link
Contributor

This adds two new parameters for modeling of nodal and apsidal precession: NodalPeriod and ApsidalPeriod. The default unit for both is years.

Example syntax (orbit data from 16 Cyg Bb):

	EllipticalOrbit
	{
		Epoch 2456937
		Period 2.18863792
		SemiMajorAxis 1.6795
		Eccentricity 0.683
		Inclination 137.41309
		AscendingNode 316.95447
		ArgOfPericenter 232.8624
		MeanAnomaly 1.03341
		NodalPeriod 100
		ApsidalPeriod 100
	}

For the following images, I've set OrbitPeriodsShown to 3.0 in celestia.cfg.

Nodal precession:

Apsidal precession:

One issue is that the orbit paths look incomplete (this is with fading disabled). I wonder if using some parameter other than period (such as eccentric anomaly) for sampling the orbit would address that.

I'm not sure if the equations used are correct either.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant