Skip to content

Commit b97cfdd

Browse files
matthewrobertsonmatthewrobertson
authored
feat: Enable cloudevent conversion logic (GoogleCloudPlatform#321)
This commit re-enables the logic to automatically convert between legacy and cloudevent request payloads to match the configured signature type. This was reverted in GoogleCloudPlatform#289. Now that we have a plan for how it will work, we should re-enable it. This reverts commit d894b49.
1 parent 4f9474d commit b97cfdd

14 files changed

+6493
-60
lines changed

‎.github/workflows/conformance.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
run: npm install
3333

3434
- name: Run HTTP conformance tests
35-
uses: GoogleCloudPlatform/functions-framework-conformance/action@v0.3.10
35+
uses: GoogleCloudPlatform/functions-framework-conformance/action@v1.0.0
3636
with:
3737
functionType: 'http'
3838
useBuildpacks: false
@@ -41,19 +41,19 @@ jobs:
4141
cmd: "'npm start -- --target=writeHttp --signature-type=http'"
4242

4343
- name: Run event conformance tests
44-
uses: GoogleCloudPlatform/functions-framework-conformance/action@v0.3.10
44+
uses: GoogleCloudPlatform/functions-framework-conformance/action@v1.0.0
4545
with:
4646
functionType: 'legacyevent'
4747
useBuildpacks: false
48-
validateMapping: false
48+
validateMapping: true
4949
workingDirectory: 'test/conformance'
5050
cmd: "'npm start -- --target=writeLegacyEvent --signature-type=event'"
5151

5252
- name: Run cloudevent conformance tests
53-
uses: GoogleCloudPlatform/functions-framework-conformance/action@v0.3.10
53+
uses: GoogleCloudPlatform/functions-framework-conformance/action@v1.0.0
5454
with:
5555
functionType: 'cloudevent'
5656
useBuildpacks: false
57-
validateMapping: false
57+
validateMapping: true
5858
workingDirectory: 'test/conformance'
5959
cmd: "'npm start -- --target=writeCloudEvent --signature-type=cloudevent'"

0 commit comments

Comments
 (0)