Array.sorted(like:keyPath:) performance improvement (#1226)

fallwd · web-flow · commit 19d8965d9fa8 · 2024-12-13T16:27:39.000+01:00
Using a Dictionary(uniqueKeysWithValues:) is more efficient than reduce(into:). I used time profile and found a significant improvement.
diff --git a/Sources/SwifterSwift/SwiftStdlib/ArrayExtensions.swift b/Sources/SwifterSwift/SwiftStdlib/ArrayExtensions.swift
@@ -58,7 +58,7 @@ public extension Array {
     ///   - keyPath: keyPath indicating the property that the array should be sorted by
     /// - Returns: sorted array.
     func sorted<T: Hashable>(like otherArray: [T], keyPath: KeyPath<Element, T>) -> [Element] {
-        let dict = otherArray.enumerated().reduce(into: [:]) { $0[$1.element] = $1.offset }
+        let dict = Dictionary(uniqueKeysWithValues: otherArray.enumerated().map { ($1, $0) })
         return sorted {
             guard let thisIndex = dict[$0[keyPath: keyPath]] else { return false }
             guard let otherIndex = dict[$1[keyPath: keyPath]] else { return true }
