Fix test_hvc_monte_carlo test

blankjul · blankjul · commit 0cc19cdcd831 · 2025-06-28T14:42:36.000-07:00
diff --git a/pymoo/indicators/hv/monte_carlo.py b/pymoo/indicators/hv/monte_carlo.py
@@ -34,9 +34,10 @@ def hvc_monte_carlo(dom, V, n_dom=None, k=1):
 
 class ApproximateMonteCarloHypervolume(DynamicHypervolume):
 
-    def __init__(self, ref_point, n_samples=10000, n_exclusive=1, **kwargs) -> None:
+    def __init__(self, ref_point, n_samples=10000, n_exclusive=1, random_state=None, **kwargs) -> None:
         self.n_samples = n_samples
         self.n_exclusive = n_exclusive
+        self.random_state = random_state if random_state is not None else np.random.RandomState(1)
 
         self.V = None
         self.dom = None
@@ -49,7 +50,7 @@ def _calc(self, ref_point, F):
         ideal = F.min(axis=0)
         V = np.prod(ref_point - ideal)
 
-        S = np.random.uniform(low=ideal, high=ref_point, size=(self.n_samples, M))
+        S = self.random_state.uniform(low=ideal, high=ref_point, size=(self.n_samples, M))
 
         dom = np.array([np.all(F[i] <= S, axis=1) for i in range(N)])
 
diff --git a/tests/indicators/test_hv.py b/tests/indicators/test_hv.py
@@ -59,8 +59,8 @@ def test_hvc_2d():
 
 
 @pytest.mark.parametrize('case', [case_2d(), case_3d()])
-@pytest.mark.skip(reason='fails since HV moocore updated. need to be checked.')
 def test_hvc_monte_carlo(case):
+    random_state = np.random.RandomState(1)
     ref_point, F = case
 
     exact = ExactHypervolume(ref_point).add(F)
@@ -70,7 +70,7 @@ def test_hvc_monte_carlo(case):
     np.testing.assert_allclose(exact.hvc, mc.hvc, rtol=0, atol=1e-1)
 
     for i in range(len(F)):
-        k = np.random.randint(low=0, high=len(F) - i)
+        k = random_state.randint(low=0, high=len(F) - i)
 
         exact.delete(k)
         mc.delete(k)
