Fix #144307: Smooth brush uses selection even with mask is disabled.

casey-1103 · Falk David · commit aad88634b611 · 2025-08-11T18:27:44.000+02:00
The problem was that the function `smooth_curve_positions` would grab the selection attribute instead of taking the current mask. Pull Request: https://projects.blender.org/blender/blender/pulls/144316
diff --git a/source/blender/editors/sculpt_paint/grease_pencil_sculpt_smooth.cc b/source/blender/editors/sculpt_paint/grease_pencil_sculpt_smooth.cc
@@ -147,8 +147,13 @@ void SmoothOperation::on_stroke_extended(const bContext &C, const InputSample &e
 
         bool changed = false;
         if (sculpt_mode_flag & GP_SCULPT_FLAGMODE_APPLY_POSITION) {
-          geometry::smooth_curve_positions(
-              curves, curves.curves_range(), iterations, influences, false, false);
+          geometry::smooth_curve_positions(curves,
+                                           curves.curves_range(),
+                                           selection_varray,
+                                           iterations,
+                                           influences,
+                                           false,
+                                           false);
 
           params.drawing.tag_positions_changed();
           changed = true;
diff --git a/source/blender/geometry/GEO_smooth_curves.hh b/source/blender/geometry/GEO_smooth_curves.hh
@@ -60,12 +60,14 @@ void smooth_curve_attribute(const IndexMask &curves_to_smooth,
  */
 void smooth_curve_positions(bke::CurvesGeometry &curves,
                             const IndexMask &curves_to_smooth,
+                            const VArray<bool> &point_selection,
                             int iterations,
                             const VArray<float> &influence_by_point,
                             bool smooth_ends,
                             bool keep_shape);
 void smooth_curve_positions(bke::CurvesGeometry &curves,
                             const IndexMask &curves_to_smooth,
+                            const VArray<bool> &point_selection,
                             int iterations,
                             float influence,
                             bool smooth_ends,
diff --git a/source/blender/geometry/intern/smooth_curves.cc b/source/blender/geometry/intern/smooth_curves.cc
@@ -245,6 +245,7 @@ void smooth_curve_attribute(const IndexMask &curves_to_smooth,
 
 void smooth_curve_positions(bke::CurvesGeometry &curves,
                             const IndexMask &curves_to_smooth,
+                            const VArray<bool> &point_selection,
                             const int iterations,
                             const VArray<float> &influence_by_point,
                             const bool smooth_ends,
@@ -253,8 +254,6 @@ void smooth_curve_positions(bke::CurvesGeometry &curves,
   bke::MutableAttributeAccessor attributes = curves.attributes_for_write();
   const OffsetIndices points_by_curve = curves.points_by_curve();
   const VArray<bool> cyclic = curves.cyclic();
-  const VArray<bool> point_selection = *curves.attributes().lookup_or_default<bool>(
-      ".selection", bke::AttrDomain::Point, true);
   if (!curves.has_curve_with_type(CURVE_TYPE_BEZIER)) {
     bke::GSpanAttributeWriter positions = attributes.lookup_for_write_span("position");
     smooth_curve_attribute(curves_to_smooth,
@@ -361,13 +360,15 @@ void smooth_curve_positions(bke::CurvesGeometry &curves,
 
 void smooth_curve_positions(bke::CurvesGeometry &curves,
                             const IndexMask &curves_to_smooth,
+                            const VArray<bool> &point_selection,
                             const int iterations,
                             const float influence,
                             const bool smooth_ends,
                             const bool keep_shape)
 {
   smooth_curve_positions(curves,
                          curves_to_smooth,
+                         point_selection,
                          iterations,
                          VArray<float>::from_single(influence, curves.points_num()),
                          smooth_ends,
