Skip to content

fix: improve page inaccessible exception handling #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: improve page inaccessible exception handling #2350

wants to merge 5 commits into from

Conversation

reformedot
Copy link
Collaborator

@reformedot reformedot commented Jul 8, 2025 •
edited by cubic-dev-ai bot
Loading

Summary by cubic

Improved error handling for cases when a page becomes inaccessible during element clicks, so users now get clearer error messages instead of crashes.

  • Bug Fixes
    • Added checks for page accessibility and return helpful error messages if the page or browser is closed during actions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2025 •
edited
Loading

Agent Task Evaluation Results: 0/3 (0%)

View detailed results
Task Result Reason
browser_use_pip ❌ Fail The agent provided no output at all. It did not return the required pip installation command 'pip install browser-use'. This suggests the agent failed to perform the task or encountered an error preventing it from generating any response.
amazon_laptop ❌ Fail The agent provided no output and took no steps. It did not navigate to amazon.com, perform the search for 'laptop', or return any result. This suggests that the agent either failed to execute the task, encountered an error preventing it from proceeding, or was not triggered properly within the CI/CD pipeline.
captcha_cloudflare ❌ Fail The agent did not provide any output or perform any steps, indicating that it failed to execute the task altogether. Without any action or extracted data, it is impossible to verify whether the captcha was solved or the required hostname was obtained.

Check the evaluate-tasks job for detailed task execution logs.

@delve-auditor Delve Auditor
Copy link

delve-auditor bot commented Jul 8, 2025 •
edited
Loading

✅ No security or compliance issues detected. Reviewed everything up to ef98e0d.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► service.py
    Improve page crash and navigation error handling
    Add better error messages for inaccessible pages

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@delve-auditor Delve Auditor
Copy link

delve-auditor bot commented Jul 8, 2025

✅ No security or compliance issues detected. Reviewed everything up to c2f29a5.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Bug Fix ► browser/profile.py
    Update browser profile configuration handling
► browser/session.py
    Improve browser session management and screenshot handling
► controller/service.py
    Enhanced page inaccessible error handling
► browser_use/sync/auth.py
    Fix terminal width display
► browser_use/sync/service.py
    Fix terminal width display
Configuration changes ► eval.yaml
    Simplify Playwright browser installation
► test.yaml
    Update test workflow configuration
► pyproject.toml
    Update package version and dependencies
Refactor ► tests/ci/test_browser_session_screenshots.py
    Refactor screenshot testing logic

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@delve-auditor Delve Auditor
Copy link

delve-auditor bot commented Jul 8, 2025

✅ No security or compliance issues detected. Reviewed everything up to af69761.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Bug Fix ► browser/profile.py
    Simplify Chrome arguments handling
► browser/session.py
    Improve screenshot handling and process detection
► controller/service.py
    Enhance page crash handling
► browser_use/sync/auth.py
    Update terminal formatting
► browser_use/sync/service.py
    Fix terminal width calculations
Configuration changes ► workflows/eval.yaml
    Simplify Playwright browser installation
► workflows/test.yaml
    Update Playwright configuration
► pyproject.toml
    Update package versions
Refactor ► tests/ci/test_browser_session_screenshots.py
    Streamline screenshot testing implementation

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reformedot @pirate