Skip to content

refactor: rename OrganizationRepository to PrismaOrganizationRepository #22918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

eunjae-lee
Copy link
Contributor

refactor: rename OrganizationRepository to PrismaOrganizationRepository

Summary

This PR renames the OrganizationRepository class to PrismaOrganizationRepository to follow the established naming convention for Prisma-backed repositories in the codebase. The changes include:

  • File rename: packages/lib/server/repository/organization.tsPrismaOrganizationRepository.ts
  • Class rename: OrganizationRepositoryPrismaOrganizationRepository
  • Fixture rename: OrganizationRepositoryFixturePrismaOrganizationRepositoryFixture
  • Import updates: Updated all import references across 59 files throughout the codebase
  • ESLint fixes: Resolved linting errors by removing unused variables and fixing TypeScript any usage

Review & Testing Checklist for Human

  • Run full test suite - Verify that all tests pass after the class/file renames (type checking alone is insufficient)
  • Test organization flows end-to-end - Manually test key organization creation, membership, and settings functionality
  • Verify import correctness - Check that all import paths are correct and no broken imports exist
  • Search for missed references - Look for any remaining string literals, comments, or indirect references to old class names
  • Validate fixture functionality - Ensure test fixtures work correctly after OrganizationRepositoryFixturePrismaOrganizationRepositoryFixture rename

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    POR["packages/lib/server/repository/<br/>PrismaOrganizationRepository.ts"]:::major-edit
    PORF["test/fixtures/repository/<br/>organization.repository.fixture.ts"]:::major-edit
    
    API1["apps/api/v2/src/modules/<br/>organizations/controllers/*.ts"]:::minor-edit
    API2["apps/api/v2/src/modules/<br/>billing/controllers/*.ts"]:::minor-edit
    API3["apps/api/v2/src/modules/<br/>teams/*/controllers/*.ts"]:::minor-edit
    
    TESTS["Various test files<br/>(*.e2e-spec.ts, *.test.ts)"]:::minor-edit
    
    CORE["Core organization logic<br/>(createOrganization, etc.)"]:::context
    
    POR --> API1
    POR --> API2  
    POR --> API3
    POR --> CORE
    
    PORF --> TESTS
    TESTS --> POR
    
    subgraph Legend
        L1["Major Edit<br/>(renamed files/classes)"]:::major-edit
        L2["Minor Edit<br/>(import updates)"]:::minor-edit
        L3["Context/No Edit"]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB  
    classDef context fill:#FFFFFF
Loading

Notes

  • This refactor maintains backward compatibility in terms of functionality - only names have changed
  • The rename follows the existing pattern used by other Prisma repository classes in the codebase
  • All ESLint and TypeScript errors have been resolved, but comprehensive testing is still needed
  • Link to Devin run: https://app.devin.ai/sessions/abb058c5d273474da4bf9e0f35511ac2
  • Requested by: @eunjae-lee

- Rename file from organization.ts to PrismaOrganizationRepository.ts
- Rename OrganizationRepository class to PrismaOrganizationRepository
- Rename OrganizationRepositoryFixture to PrismaOrganizationRepositoryFixture
- Update all import references throughout the codebase
- Fix ESLint errors by removing unused variables and imports
- Fix TypeScript any type usage in test files

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Contributor

coderabbitai bot commented Aug 6, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/rename-organization-repository-1754468371

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

… credential tests

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
Copy link

vercel bot commented Aug 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Aug 7, 2025 1:23pm
cal-eu ⬜️ Ignored (Inspect) Aug 7, 2025 1:23pm

Copy link
Contributor

github-actions bot commented Aug 7, 2025

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants