fix: prevent booking references with empty UIDs when calendar event creation fails #22986
+74
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reation fails - Filter out failed calendar events before creating booking references in EventManager.create() and updateLocation() - Add warning logs when skipping reference creation due to failures - Ensures BookingReference schema validation (uid must be non-empty) is respected - Maintains existing error logging for debugging calendar creation failures Log messages for debugging: - Look for 'createEvent failed' messages in CalendarManager.ts for calendar creation failures - Look for 'Skipping booking reference creation for failed [type] event' warnings when references are filtered out - Look for 'BookingCreatingMeetingFailed' error code in handleNewBooking.ts when all calendar events fail Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- Remove expectation of booking reference with empty UID when calendar creation fails - Aligns with new behavior that prevents schema constraint violations - Test now expects no booking reference for failed calendar events - Remove outdated comment about uncertain purpose of empty UID references Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: prevent booking references with empty UIDs when calendar event creation fails
Summary
This PR fixes an issue where booking references were being created with empty UIDs when Google Calendar event creation failed. The system was previously writing booking references to the database even when calendar events failed to be created, violating the BookingReference schema constraint that requires non-empty UIDs.
Root Cause: In
EventManager.ts, thereferencesToCreatearray was being populated from all calendar/video creation results, including failed ones whereresult.createdEvent?.idwas null/undefined, leading to empty UID strings.Solution: Added filtering logic in both
EventManager.create()andEventManager.updateLocation()methods to exclude failed calendar events before creating booking references. Only events withresult.success === trueAND a valid UID are now included.Changes Made:
EventManager.create()to filter results before mapping toreferencesToCreateEventManager.updateLocation()with the same filtering logicCalendarManager.tsfor debugging calendar failuresReview & Testing Checklist for Human
result.success && (valid UID)condition properly distinguishes between successful and failed calendar/video eventsDiagram
%%{ init : { "theme" : "default" }}%% graph TD handleNewBooking["packages/features/bookings/lib/<br/>handleNewBooking.ts"]:::context EventManager["packages/lib/<br/>EventManager.ts"]:::major-edit CalendarManager["packages/lib/<br/>CalendarManager.ts"]:::context BookingRefSchema["packages/prisma/<br/>schema.prisma<br/>(BookingReference model)"]:::context handleNewBooking -->|"creates booking references<br/>from referencesToCreate"| EventManager EventManager -->|"calls createEvent()<br/>for calendar/video"| CalendarManager CalendarManager -->|"returns success/failure<br/>results"| EventManager EventManager -->|"filters failed events<br/>BEFORE creating references"| BookingRefSchema subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
Log Messages for Debugging:
createEvent failedmessages in CalendarManager.ts for calendar creation failuresSkipping booking reference creation for failed [type] eventwarnings when references are filtered outBookingCreatingMeetingFailederror code in handleNewBooking.ts when all calendar events failSchema Constraint: The BookingReference model requires non-empty uid field (
@zod.min(1)), so filtering out empty UIDs prevents database constraint violations.Link to Devin run: https://app.devin.ai/sessions/102305fdf3db4f80b2e92e5e047bf037
Requested by: @joeauyeung