feat: enable attribute-based assignment for managed event types #22989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove explicit disabling of segment functionality in handleChildrenEventTypes.ts - Add segment assignment fields to unlocked managed event type properties - Export MembersSegmentWithToggle component for reuse - Include segment fields in managed event metadata initialization - Add segment assignment UI to managed event types when 'Assign all team members' is enabled - Update teams/index.ts to handle segment assignment for managed events This allows managed event types to use the same attribute-based user assignment functionality that was previously only available for round robin events. Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- Remove fields that are no longer included in Prisma data objects (parentId, profileId, restrictionScheduleId, scheduleId, userId) - Add explicit title, slug, length fields that are now required - Update test expectations to match new data structure with assignRRMembersUsingSegment and rrSegmentQueryValue fields - Fix destructuring patterns to avoid duplicate variable declarations Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
- Add missing required properties (profileId, scheduleId, restrictionScheduleId) to mockUpdatedEventType - Remove profileId from destructuring where it doesn't exist in evType object - Ensure test file passes type checking Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: enable attribute-based assignment for managed event types
Summary
This PR enables attribute-based user assignment for managed event types, bringing the same functionality that was previously only available for round robin events. Previously, managed events could only use "Assign all team members" or manual host selection, but now they can filter team members based on attributes like skills, location, or other custom properties.
Key Changes:
assignRRMembersUsingSegmentandrrSegmentQueryValueto unlocked managed event type propertiesReview & Testing Checklist for Human
🔴 High Priority - Must Test:
Diagram
%%{ init : { "theme" : "default" }}%% graph TD A["EventTeamAssignmentTab.tsx<br/>Event Type Settings UI"]:::major-edit B["handleChildrenEventTypes.ts<br/>Child Event Creation Logic"]:::major-edit C["zod-utils.ts<br/>Managed Event Type Schema"]:::major-edit D["AddMembersWithSwitch.tsx<br/>Segment UI Component"]:::minor-edit E["useCreateEventType.ts<br/>Event Type Hook"]:::minor-edit F["teams/index.ts<br/>Team Member Event Updates"]:::major-edit G["getRoutedUsers.ts<br/>Booking Assignment Logic"]:::context A -->|"Shows segment UI when<br/>assignAllTeamMembers enabled"| D A -->|"Uses segment fields from"| C B -->|"Creates child events with<br/>segment configuration"| C F -->|"Updates existing events<br/>with segment data"| C E -->|"Initializes metadata with<br/>unlocked segment fields"| C B -->|"Booking flow uses<br/>segment assignment"| G F -->|"Booking flow uses<br/>segment assignment"| G subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
userId,parentId,teamId, etc.) fromallManagedEventTypePropsto resolve Prisma type conflicts. This required explicitly adding required fields liketitle,slug,lengthin the creation logic.