S3 lifecycle support (localstack#441)

ataylor284 · whummer · commit 7f35e6dd25f1 · 2017-11-05T23:46:18.000-05:00
* Use forked repo for tests. * Stubbed support for s3 lifecycle configuration. * Added test for lifecycle stubs. * Revert "Use forked repo for tests." This reverts commit fe3f22f.
diff --git a/localstack/ext/java/src/test/java/cloud/localstack/S3LifecycleTest.java b/localstack/ext/java/src/test/java/cloud/localstack/S3LifecycleTest.java
@@ -0,0 +1,56 @@
+package cloud.localstack;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collections;
+import java.util.UUID;
+
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.http.entity.ContentType;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import com.amazonaws.services.s3.AmazonS3;
+import com.amazonaws.services.s3.model.BucketLifecycleConfiguration;
+import com.amazonaws.services.s3.model.Tag;
+import com.amazonaws.services.s3.model.lifecycle.LifecycleFilter;
+import com.amazonaws.services.s3.model.lifecycle.LifecycleFilterPredicate;
+import com.amazonaws.services.s3.model.lifecycle.LifecycleTagPredicate;
+
+/**
+ * Test that S3 bucket lifecycle settings can be set and read.
+ */
+@RunWith(LocalstackTestRunner.class)
+public class S3LifecycleTest {
+
+	@Test
+	public void testSetBucketLifecycle() throws Exception {
+		AmazonS3 client = TestUtils.getClientS3();
+
+		String bucketName = UUID.randomUUID().toString();
+		client.createBucket(bucketName);
+
+		BucketLifecycleConfiguration.Rule rule = new BucketLifecycleConfiguration.Rule()
+			.withId("expirationRule")
+			.withFilter(new LifecycleFilter(new LifecycleTagPredicate(new Tag("deleted", "true"))))
+			.withExpirationInDays(3)
+			.withStatus(BucketLifecycleConfiguration.ENABLED);
+
+		BucketLifecycleConfiguration bucketLifecycleConfiguration = new BucketLifecycleConfiguration()
+			.withRules(rule);
+
+		client.setBucketLifecycleConfiguration(bucketName, bucketLifecycleConfiguration);
+
+		bucketLifecycleConfiguration = client.getBucketLifecycleConfiguration(bucketName);
+
+		assertNotNull(bucketLifecycleConfiguration);
+		assertEquals(bucketLifecycleConfiguration.getRules().get(0).getId(), "expirationRule");
+
+		client.deleteBucket(bucketName);
+	}
+}
diff --git a/localstack/services/s3/s3_listener.py b/localstack/services/s3/s3_listener.py
@@ -24,6 +24,9 @@
 # mappings for bucket CORS settings
 BUCKET_CORS = {}
 
+# mappings for bucket lifecycle settings
+BUCKET_LIFECYCLE = {}
+
 # set up logger
 LOGGER = logging.getLogger(__name__)
 
@@ -209,6 +212,30 @@ def append_cors_headers(bucket_name, request_method, request_headers, response):
                     break
 
 
+def get_lifecycle(bucket_name):
+    response = Response()
+    lifecycle = BUCKET_LIFECYCLE.get(bucket_name)
+    if not lifecycle:
+        # TODO: check if bucket exists, otherwise return 404-like error
+        lifecycle = {
+            'LifecycleConfiguration': []
+        }
+    body = xmltodict.unparse(lifecycle)
+    response._content = body
+    response.status_code = 200
+    return response
+
+
+def set_lifecycle(bucket_name, lifecycle):
+    # TODO: check if bucket exists, otherwise return 404-like error
+    if isinstance(to_str(lifecycle), six.string_types):
+        lifecycle = xmltodict.parse(lifecycle)
+    BUCKET_LIFECYCLE[bucket_name] = lifecycle
+    response = Response()
+    response.status_code = 200
+    return response
+
+
 def strip_chunk_signatures(data):
     # For clients that use streaming v4 authentication, the request contains chunk signatures
     # in the HTTP body (see example below) which we need to strip as moto cannot handle them
@@ -429,6 +456,12 @@ def forward_request(self, method, path, data, headers):
             if method == 'DELETE':
                 return delete_cors(bucket)
 
+        if query == 'lifecycle' or 'lifecycle' in query_map:
+            if method == 'GET':
+                return get_lifecycle(bucket)
+            if method == 'PUT':
+                return set_lifecycle(bucket, data)
+
         if modified_data:
             return Request(data=modified_data, headers=headers, method=method)
         return True
@@ -455,7 +488,7 @@ def return_response(self, method, path, data, headers, response):
             if len(path[1:].split('/')[1]) > 0:
                 parts = parsed.path[1:].split('/', 1)
                 # ignore bucket notification configuration requests
-                if parsed.query != 'notification':
+                if parsed.query != 'notification' and parsed.query != 'lifecycle':
                     object_path = parts[1] if parts[1][0] == '/' else '/%s' % parts[1]
                     send_notifications(method, bucket_name, object_path)
 
