Rsync does not check emptyness of "became" option (#4074)

TheRatG · web-flow · commit 72a3d842b22b · 2025-05-15T18:21:59.000+02:00
#4073
diff --git a/src/Utility/Rsync.php b/src/Utility/Rsync.php
@@ -67,7 +67,7 @@ public function call(Host $host, $source, string $destination, array $config = [
         if ($connectionOptions !== '') {
             $options = array_merge($options, ['-e', "ssh $connectionOptions"]);
         }
-        if ($host->has("become")) {
+        if ($host->has('become') && !empty($host->get('become'))) {
             $options = array_merge($options, ['--rsync-path', "sudo -H -u {$host->get('become')} rsync"]);
         }
         if (!is_array($source)) {

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function call(Host $host, $source, string $destination, array $config = [`
`67`	`67`	`if ($connectionOptions !== '') {`
`68`	`68`	`$options = array_merge($options, ['-e', "ssh $connectionOptions"]);`
`69`	`69`	`}`
`70`		`- if ($host->has("become")) {`
	`70`	`+ if ($host->has('become') && !empty($host->get('become'))) {`
`71`	`71`	`$options = array_merge($options, ['--rsync-path', "sudo -H -u {$host->get('become')} rsync"]);`
`72`	`72`	`}`
`73`	`73`	`if (!is_array($source)) {`