FIX: clone object to resolve object mutation bug during autocomplete transform in chat

tyb-talks · tyb-talks · commit 071e82140cf3 · 2025-08-11T10:34:39.000+08:00
diff --git a/plugins/chat/assets/javascripts/discourse/components/chat-composer.gjs b/plugins/chat/assets/javascripts/discourse/components/chat-composer.gjs
@@ -482,7 +482,7 @@ export default class ChatComposer extends Component {
       autoSelectFirstSuggestion: true,
       transformComplete: (obj) => {
         if (obj.isUser) {
-          this.#addMentionedUser(obj);
+          this.#addMentionedUser(cloneJSON(obj));
         }
 
         return obj.username || obj.name;

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ export default class ChatComposer extends Component {`
`482`	`482`	`autoSelectFirstSuggestion: true,`
`483`	`483`	`transformComplete: (obj) => {`
`484`	`484`	`if (obj.isUser) {`
`485`		`- this.#addMentionedUser(obj);`
	`485`	`+ this.#addMentionedUser(cloneJSON(obj));`
`486`	`486`	`}`
`487`	`487`
`488`	`488`	`return obj.username \|\| obj.name;`