Skip to content

Commit a3dc356

Browse files
committed
FIX: url escaping on rich editor when autolink/linkify
1 parent 97f8c21 commit a3dc356

File tree

2 files changed

+9
-0
lines changed
  • app/assets/javascripts/discourse
    • app/static/prosemirror/extensions
    • tests/integration/components/prosemirror-editor

2 files changed

+9
-0
lines changed

app/assets/javascripts/discourse/app/static/prosemirror/extensions/link.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,16 +76,20 @@ const extension = {
7676
state.linkMarkup = mark.attrs.markup;
7777

7878
if (state.linkMarkup === "autolink") {
79+
state.inAutolink = true;
7980
return "<";
8081
}
8182

8283
if (state.linkMarkup === "linkify") {
84+
state.inAutolink = true;
8385
return "";
8486
}
8587

8688
return "[";
8789
},
8890
close(state, mark) {
91+
state.inAutolink = false;
92+
8993
const { linkMarkup } = state;
9094
state.linkMarkup = undefined;
9195

app/assets/javascripts/discourse/tests/integration/components/prosemirror-editor/link-test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ module(
2323
'<p><a href="https://example.com" data-markup="autolink">https://example.com</a></p>',
2424
"<https://example.com>",
2525
],
26+
"auto links with ~": [
27+
"<https://example.com/~user> https://example.com/~user",
28+
'<p><a href="https://example.com/~user" data-markup="autolink">https://example.com/~user</a> <a href="https://example.com/~user" data-markup="linkify">https://example.com/~user</a></p>',
29+
"<https://example.com/~user> https://example.com/~user",
30+
],
2631
"attachment link": [
2732
"[File|attachment](https://example.com/file.pdf)",
2833
'<p><a href="https://example.com/file.pdf" class="attachment">File</a></p>',

0 commit comments

Comments
 (0)