Skip to content

UX: Category header restyle #34081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 7, 2025
Merged

UX: Category header restyle #34081

merged 6 commits into from
Aug 7, 2025
+67 −20

Conversation

jordanvidrine
Copy link
Contributor

@jordanvidrine jordanvidrine commented Aug 4, 2025 •
edited
Loading

This PR applies better styling to the category title & description that appears when a category logo is uploaded.

Before After
CleanShot 2025-08-04 at 17 22 46@2x CleanShot 2025-08-04 at 17 21 11@2x
CleanShot 2025-08-04 at 17 23 40@2x CleanShot 2025-08-04 at 17 24 03@2x

@jordanvidrine jordanvidrine reopened this Aug 5, 2025
awesomerobot
awesomerobot reviewed Aug 5, 2025
View reviewed changes
awesomerobot
awesomerobot reviewed Aug 5, 2025
View reviewed changes
@CvX
Copy link
Contributor

CvX commented Aug 5, 2025

Would this work visually w/o a border? Kinda like the topic title on a topic page?

@awesomerobot
Copy link
Member

The logo might be too tiny now? should we have a little hierarchy of the current category vs subcategories? they're pretty much the same now

image

awesomerobot
awesomerobot approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@awesomerobot awesomerobot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! should be able to preemptively add border: none; in .category-heading to themes before merging to avoid regressions?

@jordanvidrine
Copy link
Contributor Author

Looks good to me! should be able to preemptively add border: none; in .category-heading to themes before merging to avoid regressions?

Seems like a good idea

@jordanvidrine jordanvidrine merged commit 456c345 into main Aug 7, 2025
16 checks passed
@jordanvidrine jordanvidrine deleted the category-header branch August 7, 2025 12:18
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/update-changed-the-category-logo-settings-and-now-all-the-pictures-are-microscopic-revertable/377869/5

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/update-changed-the-category-logo-settings-and-now-all-the-pictures-are-microscopic-revertable/377869/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awesomerobot awesomerobot awesomerobot approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordanvidrine @CvX @awesomerobot @discoursebot