Skip to content

DEV: add a visited link system spec #34140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

Conversation

ZogStriP
Copy link
Member

@ZogStriP ZogStriP commented Aug 7, 2025

That ensures visited topics have a different (font) color than not-yet visited topics in the topics lists.

This might help prevent commits like f6a1648

That ensures visited topics have a different (font) color than not-yet
visited topics in the topics lists.

This might help prevent commits like f6a1648
@ZogStriP
Copy link
Member Author

ZogStriP commented Aug 7, 2025

@jordanvidrine this should catch regressions in visited links styling 😉

@ZogStriP ZogStriP requested a review from Copilot August 7, 2025 15:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a system test to verify that visited topics display with a different color than unvisited topics in topic lists. This helps prevent regressions where visited link styling might be accidentally removed or modified.

  • Adds a new system test that creates both visited and unvisited topics
  • Tests that the color styling differs between visited and unvisited topic links
  • Uses CSS selectors to compare the actual rendered color values

Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea! We'd probably want to do the same for Horizon? Though I would like to be wary of the "costs" of system specs (they're slow).

@ZogStriP ZogStriP merged commit 890c438 into main Aug 7, 2025
16 checks passed
@ZogStriP ZogStriP deleted the add-visited-links-system-spec branch August 7, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants