ref(autofix): Reuse the organization trace endpoint to simplify logic #97550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #97550 +/- ##
==========================================
- Coverage 80.62% 80.61% -0.01%
==========================================
Files 8560 8560
Lines 376889 376725 -164
Branches 24538 24538
==========================================
- Hits 303865 303706 -159
+ Misses 72654 72649 -5
Partials 370 370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracing logic didn't seem to be working quite right, and it was super complex and unmaintainable anyway to try to mold it into the old transaction-based logic.
So this PR simplifies things by just reusing the OrganizationTraceEndpoint, similar to the AI trace summary endpoint. On the Seer side, we'll also need to make changes to support the new data structure.
Seer PR: https://github.com/getsentry/seer/pull/3117