fix(issue summary): Close database connections after issue summary generation #97555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97555 +/- ##
=======================================
Coverage 80.62% 80.62%
=======================================
Files 8560 8560
Lines 376889 376894 +5
Branches 24538 24538
=======================================
+ Hits 303865 303871 +6
+ Misses 72654 72653 -1
Partials 370 370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-4BWM. The issue was that: ThreadPoolExecutor's new threads request database connections, exhausting PostgreSQL's max_client_conn due to unreleased connections.
get_issue_summaryfunction call in a thread with a function_get_issue_summary_with_cleanupto ensure database connections are closed after the thread execution.This fix was generated by Seer in Sentry, triggered by Rohan Agarwal. 👁️ Run ID: 734760
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.