Cleanup extract to toolcache feature flag #3021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the "extract to toolcache" feature flag that has been successfully rolled out for several months, simplifying the CodeQL bundle extraction code by eliminating the conditional behavior.
- Removes the
ExtractToToolcacheandZstdBundleStreamingExtractionfeature flags from the feature flags system - Simplifies CodeQL bundle extraction logic by removing the conditional paths and always using the new extraction behavior
- Updates function signatures across the codebase to remove the now-unnecessary
featuresparameter
Reviewed Changes
Copilot reviewed 16 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/feature-flags.ts | Removes the ExtractToToolcache and ZstdBundleStreamingExtraction feature flag definitions |
| src/setup-codeql.ts | Removes feature flag parameter and simplifies downloadCodeQL function by removing conditional extraction logic |
| src/upload-lib.ts | Removes features parameter from initCodeQL call |
| src/init.ts | Removes features parameter from initCodeQL function signature |
| src/init-action.ts | Removes features parameter from initCodeQL call |
| src/codeql.ts | Removes features parameter from setupCodeQL function signature |
| src/setup-codeql.test.ts | Updates test calls to remove features parameter |
| src/codeql.test.ts | Removes feature-related test utilities and updates test calls |
| lib/*.js | Generated JavaScript files mirroring the TypeScript changes |
Comments suppressed due to low confidence (7)
src/codeql.test.ts:170
- Extra blank line added on line 169. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:204
- Extra blank line added on line 203. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:287
- Extra blank line added on line 286. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:320
- Extra blank line added on line 319. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:357
- Extra blank line added on line 357. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:391
- Extra blank line added on line 391. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:427
- Extra blank line added on line 427. This appears to be an unintentional formatting change that should be removed.
false,
mbg
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
All LGTM, thanks!
Minor point: Reviewing the commit that removes the extract-directly-to-toolcache FF would have benefitted from a link to #2631 in the commit message or PR description to point at the context for this to make it quicker to review.
|
Looks like the PR checks also need updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been rolled out for a couple of months without any issues, so remove the feature flag and clean up the old code paths.
Merge / deployment checklist