fix test expectations for no teams found

mattdholloway · mattdholloway · commit 8a332fcb479b · 2025-08-08T17:57:27.000+01:00
diff --git a/pkg/github/context_tools.go b/pkg/github/context_tools.go
@@ -157,7 +157,7 @@ func GetTeams(getClient GetClientFn, getGQLClient GetGQLClientFn, t translations
 			return mcp.NewToolResultError(err.Error()), nil
 		}
 
-		return MarshalledTextResult(t), nil
+		return MarshalledTextResult(q.User.Organizations.Nodes), nil
 	})
 
 	return tool, handler
diff --git a/pkg/github/context_tools_test.go b/pkg/github/context_tools_test.go
@@ -285,8 +285,8 @@ func Test_GetTeams(t *testing.T) {
 				return githubv4.NewClient(httpClient), nil
 			},
 			requestArgs:        map[string]any{},
-			expectToolError:    true,
-			expectedToolErrMsg: "no teams found for user",
+			expectToolError:    false,
+			expectedTeamsCount: 0,
 		},
 		{
 			name:                  "getting client fails",
@@ -366,9 +366,11 @@ func Test_GetTeams(t *testing.T) {
 				assert.Equal(t, "team1", organizations[0].Teams.Nodes[0].Name)
 				assert.Equal(t, "team1", organizations[0].Teams.Nodes[0].Slug)
 
-				assert.Equal(t, "testorg2", organizations[1].Login)
-				assert.Len(t, organizations[1].Teams.Nodes, 1)
-				assert.Equal(t, "team3", organizations[1].Teams.Nodes[0].Name)
+				if tc.expectedTeamsCount > 1 {
+					assert.Equal(t, "testorg2", organizations[1].Login)
+					assert.Len(t, organizations[1].Teams.Nodes, 1)
+					assert.Equal(t, "team3", organizations[1].Teams.Nodes[0].Name)
+				}
 			}
 		})
 	}

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ func GetTeams(getClient GetClientFn, getGQLClient GetGQLClientFn, t translations`
`157`	`157`	`return mcp.NewToolResultError(err.Error()), nil`
`158`	`158`	`}`
`159`	`159`
`160`		`- return MarshalledTextResult(t), nil`
	`160`	`+ return MarshalledTextResult(q.User.Organizations.Nodes), nil`
`161`	`161`	`})`
`162`	`162`
`163`	`163`	`return tool, handler`