package.json: deprecate goformat

alexandear · hyangah · commit fe8bfac74aeb · 2025-01-15T10:28:22.000-08:00
goformat can't format modern Go code that uses generics. See mbenkmann/goformat#2 Change-Id: I6ef36db10677fd7e31ea20bb95d75db5d152edd1 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/641875 Reviewed-by: Michael Knyszek <mknyszek@google.com> Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
diff --git a/docs/settings.md b/docs/settings.md
@@ -242,7 +242,7 @@ Allowed Options:
 * `default`: If the language server is enabled, format via the language server, which already supports gofmt, goimports, goreturns, and gofumpt. Otherwise, goimports.
 * `gofmt`: Formats the file according to the standard Go style. (not applicable when the language server is enabled)
 * `goimports`: Organizes imports and formats the file with gofmt. (not applicable when the language server is enabled)
-* `goformat`: Configurable gofmt, see https://github.com/mbenkmann/goformat.
+* `goformat`: Configurable gofmt, see https://github.com/mbenkmann/goformat. (Deprecated due to the lack of generics support)
 * `gofumpt`: Stricter version of gofmt, see https://github.com/mvdan/gofumpt. . Use `#gopls.format.gofumpt#` instead)
 * `custom`: Formats using the custom tool specified as `customFormatter` in the `#go.alternateTools#` setting. The tool should take the input as STDIN and output the formatted code as STDOUT.
 
diff --git a/extension/package.json b/extension/package.json
@@ -1228,7 +1228,7 @@
             "If the language server is enabled, format via the language server, which already supports gofmt, goimports, goreturns, and gofumpt. Otherwise, goimports.",
             "Formats the file according to the standard Go style. (not applicable when the language server is enabled)",
             "Organizes imports and formats the file with gofmt. (not applicable when the language server is enabled)",
-            "Configurable gofmt, see https://github.com/mbenkmann/goformat.",
+            "Configurable gofmt, see https://github.com/mbenkmann/goformat. (Deprecated due to the lack of generics support)",
             "Stricter version of gofmt, see https://github.com/mvdan/gofumpt. . Use `#gopls.format.gofumpt#` instead)",
             "Formats using the custom tool specified as `customFormatter` in the `#go.alternateTools#` setting. The tool should take the input as STDIN and output the formatted code as STDOUT."
           ]

Original file line number	Diff line number	Diff line change
`@@ -1228,7 +1228,7 @@`
`1228`	`1228`	`"If the language server is enabled, format via the language server, which already supports gofmt, goimports, goreturns, and gofumpt. Otherwise, goimports.",`
`1229`	`1229`	`"Formats the file according to the standard Go style. (not applicable when the language server is enabled)",`
`1230`	`1230`	`"Organizes imports and formats the file with gofmt. (not applicable when the language server is enabled)",`
`1231`		`- "Configurable gofmt, see https://github.com/mbenkmann/goformat.",`
	`1231`	`+ "Configurable gofmt, see https://github.com/mbenkmann/goformat. (Deprecated due to the lack of generics support)",`
`1232`	`1232`	"Stricter version of gofmt, see https://github.com/mvdan/gofumpt. . Use `#gopls.format.gofumpt#` instead)",
`1233`	`1233`	"Formats using the custom tool specified as `customFormatter` in the `#go.alternateTools#` setting. The tool should take the input as STDIN and output the formatted code as STDOUT."
`1234`	`1234`	`]`