core,node,server: improve graphman reassign response type

shiyasmohd · web-flow · commit 03d2d4d69a3e · 2025-07-17T16:44:55.000+05:30
diff --git a/core/graphman/src/commands/deployment/reassign.rs b/core/graphman/src/commands/deployment/reassign.rs
@@ -49,7 +49,7 @@ pub enum ReassignDeploymentError {
 
 #[derive(Clone, Debug)]
 pub enum ReassignResult {
-    EmptyResponse,
+    Ok,
     CompletedWithWarnings(Vec<String>),
 }
 
@@ -121,6 +121,6 @@ pub fn reassign_deployment(
         let warning_msg = format!("This is the only deployment assigned to '{}'. Please make sure that the node ID is spelled correctly.",node.as_str());
         Ok(ReassignResult::CompletedWithWarnings(vec![warning_msg]))
     } else {
-        Ok(ReassignResult::EmptyResponse)
+        Ok(ReassignResult::Ok)
     }
 }
diff --git a/node/src/manager/commands/deployment/reassign.rs b/node/src/manager/commands/deployment/reassign.rs
@@ -36,7 +36,7 @@ pub fn run(
     )?;
 
     match reassign_result {
-        ReassignResult::EmptyResponse => {
+        ReassignResult::Ok => {
             println!(
                 "Deployment {} assigned to node {}",
                 deployment.locator(),
diff --git a/server/graphman/src/resolvers/deployment_mutation.rs b/server/graphman/src/resolvers/deployment_mutation.rs
@@ -27,7 +27,7 @@ pub struct DeploymentMutation;
 
 #[derive(Clone, Debug, Union)]
 pub enum ReassignResponse {
-    EmptyResponse(EmptyResponse),
+    Ok(EmptyResponse),
     CompletedWithWarnings(CompletedWithWarnings),
 }
 
@@ -124,9 +124,7 @@ impl DeploymentMutation {
             ReassignResult::CompletedWithWarnings(warnings) => Ok(
                 ReassignResponse::CompletedWithWarnings(CompletedWithWarnings::new(warnings)),
             ),
-            ReassignResult::EmptyResponse => {
-                Ok(ReassignResponse::EmptyResponse(EmptyResponse::new()))
-            }
+            ReassignResult::Ok => Ok(ReassignResponse::Ok(EmptyResponse::new())),
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ pub enum ReassignDeploymentError {`
`49`	`49`
`50`	`50`	`#[derive(Clone, Debug)]`
`51`	`51`	`pub enum ReassignResult {`
`52`		`- EmptyResponse,`
	`52`	`+ Ok,`
`53`	`53`	`CompletedWithWarnings(Vec<String>),`
`54`	`54`	`}`
`55`	`55`
`@@ -121,6 +121,6 @@ pub fn reassign_deployment(`
`121`	`121`	`let warning_msg = format!("This is the only deployment assigned to '{}'. Please make sure that the node ID is spelled correctly.",node.as_str());`
`122`	`122`	`Ok(ReassignResult::CompletedWithWarnings(vec![warning_msg]))`
`123`	`123`	`} else {`
`124`		`- Ok(ReassignResult::EmptyResponse)`
	`124`	`+ Ok(ReassignResult::Ok)`
`125`	`125`	`}`
`126`	`126`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ pub struct DeploymentMutation;`
`27`	`27`
`28`	`28`	`#[derive(Clone, Debug, Union)]`
`29`	`29`	`pub enum ReassignResponse {`
`30`		`- EmptyResponse(EmptyResponse),`
	`30`	`+ Ok(EmptyResponse),`
`31`	`31`	`CompletedWithWarnings(CompletedWithWarnings),`
`32`	`32`	`}`
`33`	`33`
`@@ -124,9 +124,7 @@ impl DeploymentMutation {`
`124`	`124`	`ReassignResult::CompletedWithWarnings(warnings) => Ok(`
`125`	`125`	`ReassignResponse::CompletedWithWarnings(CompletedWithWarnings::new(warnings)),`
`126`	`126`	`),`
`127`		`- ReassignResult::EmptyResponse => {`
`128`		`- Ok(ReassignResponse::EmptyResponse(EmptyResponse::new()))`
`129`		`- }`
	`127`	`+ ReassignResult::Ok => Ok(ReassignResponse::Ok(EmptyResponse::new())),`
`130`	`128`	`}`
`131`	`129`	`}`
`132`	`130`	`}`