minor code simplification in DriverManagerConnectionProviderImpl

gavinking · gavinking · commit 0cf6ad35ef43 · 2025-07-11T23:04:28.000+02:00
diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DriverManagerConnectionProviderImpl.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DriverManagerConnectionProviderImpl.java
@@ -9,7 +9,6 @@
 import java.sql.DriverManager;
 import java.sql.SQLException;
 import java.util.Enumeration;
-import java.util.Iterator;
 import java.util.Map;
 import java.util.Properties;
 import java.util.concurrent.ConcurrentLinkedQueue;
@@ -477,7 +476,7 @@ protected void closeConnection(Connection conn, Throwable t) {
 
 		public void close() throws SQLException {
 			try {
-				int allocationCount = allConnections.size() - availableConnections.size();
+				final int allocationCount = allConnections.size() - availableConnections.size();
 				if (allocationCount > 0) {
 					ConnectionInfoLogger.INSTANCE.error( "Connection leak detected: there are " + allocationCount + " unclosed connections upon shutting down pool " + getUrl());
 				}
@@ -653,8 +652,7 @@ private void validateConnections(ConnectionValidator validator) {
 			statelock.writeLock().lock();
 			try {
 				RuntimeException ex = null;
-				for ( Iterator<Connection> iterator = pool.allConnections.iterator(); iterator.hasNext(); ) {
-					final Connection connection = iterator.next();
+				for ( Connection connection : pool.allConnections ) {
 					SQLException e = null;
 					boolean isValid = false;
 					try {
