HHH-19630 Adjust how Hibernate Processor determines the entity type

marko-bekhta · marko-bekhta · commit c345a557ed06 · 2025-07-22T11:12:31.000+02:00
diff --git a/tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/constraint/DataTest.java b/tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/constraint/DataTest.java
@@ -19,6 +19,6 @@ void test() {
 		System.out.println( getMetaModelSourceAsString( MyEntity.class ) );
 		System.out.println( getMetaModelSourceAsString( MyConstrainedRepository.class ) );
 		assertMetamodelClassGeneratedFor( MyEntity.class );
-//		assertMetamodelClassGeneratedFor( MyConstrainedRepository.class );
+		assertMetamodelClassGeneratedFor( MyConstrainedRepository.class );
 	}
 }
diff --git a/tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/constraint/MyConstrainedRepository.java b/tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/constraint/MyConstrainedRepository.java
@@ -7,12 +7,15 @@
 import jakarta.data.repository.CrudRepository;
 import jakarta.data.repository.Find;
 import jakarta.data.repository.Repository;
+import jakarta.validation.Valid;
 import jakarta.validation.constraints.NotNull;
 import jakarta.validation.constraints.Size;
 
 @Repository
 public interface MyConstrainedRepository extends CrudRepository<MyEntity, Long> {
 
+	@Valid
+	@NotNull
 	@Find
 	MyEntity findByName(@NotNull @Size(min = 5) String name);
 }
diff --git a/tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/constraint/MyEntity.java b/tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/constraint/MyEntity.java
@@ -4,6 +4,7 @@
  */
 package org.hibernate.processor.test.data.constraint;
 
+import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
 import jakarta.persistence.Id;
 
@@ -12,5 +13,6 @@ public class MyEntity {
 
 	@Id
 	private Long id;
+	@Column(unique = true)
 	private String name;
 }
diff --git a/tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java b/tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java
@@ -2453,7 +2453,7 @@ private void createSingleParameterFinder(
 							new CriteriaFinderMethod(
 									this, method,
 									methodName,
-									returnType.toString(),
+									typeAsString( returnType, false ),
 									containerType,
 									paramNames,
 									paramTypes,
@@ -3389,25 +3389,29 @@ private List<String> parameterTypes(ExecutableElement method) {
 	 * Workaround for a bug in Java 20/21. Should not be necessary!
 	 */
 	private String typeAsString(TypeMirror type) {
-		String result;
+		return typeAsString( type, true );
+	}
+
+	private String typeAsString(TypeMirror type, boolean includeAnnotations) {
 		if ( type instanceof DeclaredType dt && dt.asElement() instanceof TypeElement te ) {
 			// get the "fqcn" without any type arguments
-			result = te.getQualifiedName().toString();
+			String result = te.getQualifiedName().toString();
 			// add the < ? ,? ....> as necessary:
 			if ( !dt.getTypeArguments().isEmpty() ) {
 				result += dt.getTypeArguments().stream()
-						.map( this::typeAsString )
-						.collect( Collectors.joining( ",", "<", ">" ) );
+						.map( arg -> typeAsString( arg, true ) )
+						.collect( Collectors.joining( ", ", "<", ">" ) );
+			}
+			if ( includeAnnotations ) {
+				for ( AnnotationMirror annotation : type.getAnnotationMirrors() ) {
+					result = annotation.toString() + ' ' + result;
+				}
 			}
+			return result;
 		}
 		else {
-			result = type.toString();
-		}
-
-		for ( AnnotationMirror annotation : type.getAnnotationMirrors() ) {
-			result = annotation.toString() + ' ' + result;
+			return type.toString();
 		}
-		return result;
 	}
 
 	private TypeMirror parameterType(VariableElement parameter) {

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,6 @@ void test() {`
`19`	`19`	`System.out.println( getMetaModelSourceAsString( MyEntity.class ) );`
`20`	`20`	`System.out.println( getMetaModelSourceAsString( MyConstrainedRepository.class ) );`
`21`	`21`	`assertMetamodelClassGeneratedFor( MyEntity.class );`
`22`		`-// assertMetamodelClassGeneratedFor( MyConstrainedRepository.class );`
	`22`	`+ assertMetamodelClassGeneratedFor( MyConstrainedRepository.class );`
`23`	`23`	`}`
`24`	`24`	`}`