Make FormulaWithPartitionByTest deterministic and enable partition by tests on H2

beikov · beikov · commit df6a1df87e14 · 2025-07-16T14:46:55.000+02:00
diff --git a/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacyDialect.java b/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacyDialect.java
@@ -1046,6 +1046,11 @@ public String getCaseInsensitiveLike() {
 		}
 	}
 
+	@Override
+	public boolean supportsPartitionBy() {
+		return getVersion().isSameOrAfter( 1, 4, 200 );
+	}
+
 	@Override
 	public boolean supportsCaseInsensitiveLike() {
 		return getVersion().isSameOrAfter( 1, 4, 194 );
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/H2Dialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/H2Dialect.java
@@ -1055,6 +1055,11 @@ public boolean supportsCaseInsensitiveLike(){
 		return true;
 	}
 
+	@Override
+	public boolean supportsPartitionBy() {
+		return true;
+	}
+
 	@Override
 	public boolean supportsBindingNullSqlTypeForSetNull() {
 		return true;
diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/mapping/formula/FormulaWithPartitionByTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/mapping/formula/FormulaWithPartitionByTest.java
@@ -82,6 +82,7 @@ void tearDown(SessionFactoryScope scope) {
 	public static class DisplayItem implements Serializable {
 
 		@Id
+		@Column(name = "DISPLAY_ITEM_ID")
 		private Integer id;
 
 		@Column(name = "DISCOUNT_CODE")
@@ -90,7 +91,7 @@ public static class DisplayItem implements Serializable {
 		@Column(name = "DISCOUNT_VALUE")
 		private Double discountValue;
 
-		@Formula("ROW_NUMBER() OVER( PARTITION BY DISCOUNT_CODE ORDER BY SIGN(DISCOUNT_VALUE) DESC )")
+		@Formula("ROW_NUMBER() OVER(PARTITION BY DISCOUNT_CODE ORDER BY DISPLAY_ITEM_ID)")
 		private Integer itemsByCode;
 
 		public Integer getId() {

Original file line number	Diff line number	Diff line change
`@@ -1046,6 +1046,11 @@ public String getCaseInsensitiveLike() {`
`1046`	`1046`	`}`
`1047`	`1047`	`}`
`1048`	`1048`
	`1049`	`+ @Override`
	`1050`	`+ public boolean supportsPartitionBy() {`
	`1051`	`+ return getVersion().isSameOrAfter( 1, 4, 200 );`
	`1052`	`+ }`
	`1053`	`+`
`1049`	`1054`	`@Override`
`1050`	`1055`	`public boolean supportsCaseInsensitiveLike() {`
`1051`	`1056`	`return getVersion().isSameOrAfter( 1, 4, 194 );`