Core: Stop trimming value inside required method

jzaefferer · jzaefferer · commit 2ad0ca82daf0 · 2015-06-16T19:50:11.000+02:00
There was never much of a point anyway, and it causes problems. Fixes jquery-validation#1498
diff --git a/src/core.js b/src/core.js
@@ -1143,7 +1143,7 @@ $.extend( $.validator, {
 			if ( this.checkable( element ) ) {
 				return this.getLength( value, element ) > 0;
 			}
-			return $.trim( value ).length > 0;
+			return value.length > 0;
 		},
 
 		// http://jqueryvalidation.org/email-method/
diff --git a/test/index.html b/test/index.html
@@ -203,7 +203,7 @@ <h3></h3>
 	</form>
 	<form id="form" action="formaction">
 		<input type="text" name="action" value="Test" id="text1">
-		<input type="text" name="text2" value="   " id="text1b">
+		<input type="text" name="text2" value="" id="text1b">
 		<input type="text" name="text2" value="T " id="text1c">
 		<input type="text" name="text2" value="T" id="text2">
 		<input type="text" name="text2" value="TestTestTest" id="text3">
diff --git a/test/methods.js b/test/methods.js
@@ -186,10 +186,10 @@ test("required", function() {
 		e = $("#text1, #text1b, #hidden2, #select1, #select2");
 	ok( method.call( v, e[0].value, e[0]), "Valid text input" );
 	ok(!method.call( v, e[1].value, e[1]), "Invalid text input" );
-	ok(!method.call( v, e[1].value, e[2]), "Invalid text input" );
+	ok(!method.call( v, e[2].value, e[2]), "Invalid text input" );
 
-	ok(!method.call( v, e[2].value, e[3]), "Invalid select" );
-	ok( method.call( v, e[3].value, e[4]), "Valid select" );
+	ok(!method.call( v, e[3].value, e[3]), "Invalid select" );
+	ok( method.call( v, e[4].value, e[4]), "Valid select" );
 
 	e = $("#area1, #area2, #pw1, #pw2");
 	ok( method.call( v, e[0].value, e[0]), "Valid textarea" );

Original file line number	Diff line number	Diff line change
`@@ -1143,7 +1143,7 @@ $.extend( $.validator, {`
`1143`	`1143`	`if ( this.checkable( element ) ) {`
`1144`	`1144`	`return this.getLength( value, element ) > 0;`
`1145`	`1145`	`}`
`1146`		`- return $.trim( value ).length > 0;`
	`1146`	`+ return value.length > 0;`
`1147`	`1147`	`},`
`1148`	`1148`
`1149`	`1149`	`// http://jqueryvalidation.org/email-method/`