[Fix] node 0.8: an object arg to a TA only throws a RangeError when it is an ArrayBuffer of an incompatible byte length

ljharb · ljharb · commit d5108f6d0624 · 2023-03-01T21:45:44.000-08:00
diff --git a/index.js b/index.js
@@ -35,7 +35,7 @@ module.exports = $byteLength || $abSlice
 			try {
 				return (new $Float32Array(obj)).buffer === obj && !isTypedArray(obj);
 			} catch (e) {
-				return false;
+				return typeof obj === 'object' && e.name === 'RangeError';
 			}
 		}
 		: function isArrayBuffer(obj) { // eslint-disable-line no-unused-vars
diff --git a/test/index.js b/test/index.js
@@ -21,9 +21,11 @@ test('isArrayBuffer', function (t) {
 
 	t.test('actual ArrayBuffer instances', { skip: typeof ArrayBuffer === 'undefined' }, function (st) {
 		var ab = new ArrayBuffer();
-
 		st.equal(isArrayBuffer(ab), true, inspect(ab) + ' is an ArrayBuffer');
 
+		var ab42 = new ArrayBuffer(42);
+		st.equal(isArrayBuffer(ab42), true, inspect(ab42) + ' is an ArrayBuffer');
+
 		st.end();
 	});
 

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ module.exports = $byteLength \|\| $abSlice`
`35`	`35`	`try {`
`36`	`36`	`return (new $Float32Array(obj)).buffer === obj && !isTypedArray(obj);`
`37`	`37`	`} catch (e) {`
`38`		`- return false;`
	`38`	`+ return typeof obj === 'object' && e.name === 'RangeError';`
`39`	`39`	`}`
`40`	`40`	`}`
`41`	`41`	`: function isArrayBuffer(obj) { // eslint-disable-line no-unused-vars`