Add CI TSan workflow #4624
Draft
Add CI TSan workflow #4624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96ce2f6 to
cdf6f06
Compare
dloebl
commented
Aug 6, 2025
| TSAN_DSO=`$CC -print-file-name=libclang_rt.tsan-x86_64.so` | ||
| echo "LDSHARED=$CC -shared" >> $GITHUB_ENV | ||
| echo "CPPFLAGS=-g -fsanitize=thread -fno-sanitize=function -fno-omit-frame-pointer -fopenmp -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION" >> $GITHUB_ENV | ||
| echo "LDFLAGS=-g -fsanitize=thread -shared-libasan -fopenmp=libomp" >> $GITHUB_ENV |
There was a problem hiding this comment.
Linking fails without -shared-libasan (even for TSan). I'm not sure why that's the case
dloebl
commented
Aug 6, 2025
| build: { cc: clang-19, cxx: clang++-19, linker: ld.lld-19, sanitize: true } | ||
| build: { cc: clang-19, cxx: clang++-19, linker: ld.lld-19, sanitize: 'asan' } | ||
|
|
||
| - name: "Linux x64 (Ubuntu 24.04) - Clang 19 with TSan" |
There was a problem hiding this comment.
ASan and TSan aren't compatible - so I had to add a new workflow
for reference: libvips#4622 (reply in thread)
116638b to
5de22c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at adding a CI TSan workflow. This has a quite a few benefits:
masteror a release./suppressions/tsan.supp) is continuously testedThe tests are still failing and there are probably still some false-positives left. Depends on #4623.