Added charset=UTF-8 to content-type to fix encoding issues. (webpack#136)

callumacrae · SpaceK33z · commit e192bba6f481 · 2016-10-05T20:33:02.000+02:00
See webpack/webpack-dev-server#432 for bug report.
diff --git a/middleware.js b/middleware.js
@@ -240,7 +240,7 @@ module.exports = function(compiler, options) {
 			var content = fs.readFileSync(filename);
 			content = handleRangeHeaders(content, req, res);
 			res.setHeader("Access-Control-Allow-Origin", "*"); // To support XHR, etc.
-			res.setHeader("Content-Type", mime.lookup(filename));
+			res.setHeader("Content-Type", mime.lookup(filename) + "; charset=UTF-8");
 			res.setHeader("Content-Length", content.length);
 			if(options.headers) {
 				for(var name in options.headers) {
diff --git a/test/Server.test.js b/test/Server.test.js
@@ -44,7 +44,7 @@ describe("Server", function() {
 
 		it("GET request to bundle file", function(done) {
 			request(app).get("/public/bundle.js")
-			.expect("Content-Type", "application/javascript")
+			.expect("Content-Type", "application/javascript; charset=UTF-8")
 			.expect("Content-Length", "2780")
 			.expect("Access-Control-Allow-Origin", "*")
 			.expect(200, /console\.log\("Hey\."\)/, done);
@@ -57,7 +57,7 @@ describe("Server", function() {
 
 		it("request to image", function(done) {
 			request(app).get("/public/svg.svg")
-			.expect("Content-Type", "image/svg+xml")
+			.expect("Content-Type", "image/svg+xml; charset=UTF-8")
 			.expect("Content-Length", "4778")
 			.expect("Access-Control-Allow-Origin", "*")
 			.expect(200, done);
@@ -71,13 +71,13 @@ describe("Server", function() {
 
 		it("request to HMR json", function(done) {
 			request(app).get("/public/123a123412.hot-update.json")
-			.expect("Content-Type", "application/json")
+			.expect("Content-Type", "application/json; charset=UTF-8")
 			.expect(200, /\[\"hi\"\]/, done);
 		});
 
 		it("request to directory", function(done) {
 			request(app).get("/public/")
-			.expect("Content-Type", "text/html")
+			.expect("Content-Type", "text/html; charset=UTF-8")
 			.expect("Content-Length", "10")
 			.expect("Access-Control-Allow-Origin", "*")
 			.expect(200, /My\ Index\./, done);
