Skip to content

Re-enabling ruff rule E721 #12968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Re-enabling ruff rule E721 #12968

wants to merge 2 commits into from

Conversation

giograno
Copy link
Member

@giograno giograno commented Aug 7, 2025

Motivation

Following up on our efforts for a better linting (e.g., #12953 and #5018), this PR re-enables the rule E721 and adjusts the code to be compliant.

@giograno giograno self-assigned this Aug 7, 2025
@giograno giograno added the semver: patch Non-breaking changes which can be included in patch releases label Aug 7, 2025
Copy link

github-actions bot commented Aug 7, 2025

Test Results - Preflight, Unit

22 063 tests  ±0   20 329 ✅ ±0   6m 13s ⏱️ -7s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit e311256. ± Comparison against base commit 2d08a27.

Copy link

github-actions bot commented Aug 7, 2025

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   8m 31s ⏱️
  515 tests 465 ✅  50 💤 0 ❌
1 030 runs  930 ✅ 100 💤 0 ❌

Results for commit e311256.

Copy link

github-actions bot commented Aug 7, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 14s ⏱️ +9s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit e311256. ± Comparison against base commit 2d08a27.

Copy link

github-actions bot commented Aug 7, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 22s ⏱️
4 980 tests 4 393 ✅ 587 💤 0 ❌
4 986 runs  4 393 ✅ 593 💤 0 ❌

Results for commit e311256.

Copy link

github-actions bot commented Aug 7, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 7s ⏱️ -15s
4 621 tests ±0  4 186 ✅ ±0  435 💤 ±0  0 ❌ ±0 
4 623 runs  ±0  4 186 ✅ ±0  437 💤 ±0  0 ❌ ±0 

Results for commit e311256. ± Comparison against base commit 2d08a27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant