Skip to content

Commit 92147e5

Browse files
DSamaryangithub-actions[bot]
authored andcommitted
NAVAND-5918 Disconnect CoreVoiceApiClient (#9768)
* NAVAND-5918 Disconnect CoreVoiceApiClient * NAVAND-5918 Migrate audio module from ktor to common http engine * NAVAND-5918 Fix review * NAVAND-5918 Fix unit test * NAVAND-5918 Update api file * NAVAND-5918 Update showcase app proguard file GitOrigin-RevId: 372f5617a734036f99beeb232bd1bd8cce5e9af9
1 parent e295df8 commit 92147e5

File tree

4 files changed

+6
-13
lines changed

4 files changed

+6
-13
lines changed

gradle/dependencies.gradle

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ ext {
8787
toStringVerifier : '1.4.8',
8888
kotlinDateTime : '0.4.1',
8989
kotlinSerialization : '1.3.1',
90-
ktor : '2.3.0',
9190
coilVersion : '2.4.0',
9291
microsoftCognitiveSpeech : '1.34.0',
9392
lottie : '6.0.0'
@@ -215,15 +214,6 @@ ext {
215214
kotlinXDateTime : "org.jetbrains.kotlinx:kotlinx-datetime:${version.kotlinDateTime}",
216215
kotlinSerialization : "org.jetbrains.kotlinx:kotlinx-serialization-json:${version.kotlinSerialization}",
217216

218-
ktorClientCore : "io.ktor:ktor-client-core:${version.ktor}",
219-
ktorClientEncoding : "io.ktor:ktor-client-encoding:${version.ktor}",
220-
ktorClientAndroid : "io.ktor:ktor-client-android:${version.ktor}",
221-
ktorClientAuth : "io.ktor:ktor-client-auth:${version.ktor}",
222-
ktorClientOkHttp : "io.ktor:ktor-client-okhttp:${version.ktor}",
223-
ktorCio : "io.ktor:ktor-client-cio:${version.ktor}",
224-
ktorClientContentNegotiation: "io.ktor:ktor-client-content-negotiation:${version.ktor}",
225-
ktorSerialization : "io.ktor:ktor-serialization-kotlinx-json:${version.ktor}",
226-
ktorWebSockets : "io.ktor:ktor-client-websockets:${version.ktor}",
227217
microsoftCognitiveSpeech : "com.microsoft.cognitiveservices.speech:client-sdk:${version.microsoftCognitiveSpeech}",
228218
lottie : "com.airbnb.android:lottie-compose:${version.lottie}"
229219
]

voice/src/main/java/com/mapbox/navigation/voice/api/UrlUtils.kt renamed to utils/src/main/java/com/mapbox/navigation/utils/internal/UrlUtils.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@
77
*
88
* source: https://github.com/square/okhttp/blob/b4904c65bdf38fd20ca0aacb23b474c50e5c1d06/okhttp/src/jvmMain/kotlin/okhttp3/HttpUrl.kt#L1770
99
*/
10-
package com.mapbox.navigation.voice.api
11-
10+
package com.mapbox.navigation.utils.internal
1211
/* ktlint-disable */
12+
import androidx.annotation.RestrictTo
1313
import okio.Buffer
1414
import java.nio.charset.Charset
1515
import java.nio.charset.StandardCharsets.UTF_8
1616

17-
internal object UrlUtils {
17+
@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP_PREFIX)
18+
object UrlUtils {
1819

1920
private val HEX_DIGITS =
2021
charArrayOf('0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F')

voice/src/main/java/com/mapbox/navigation/voice/api/MapboxSpeechProvider.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import com.mapbox.navigation.ui.base.util.resource.ResourceLoader
1919
import com.mapbox.navigation.ui.utils.internal.resource.ResourceLoadRequest
2020
import com.mapbox.navigation.ui.utils.internal.resource.load
2121
import com.mapbox.navigation.utils.internal.ByteBufferBackedInputStream
22+
import com.mapbox.navigation.utils.internal.UrlUtils
2223
import com.mapbox.navigation.voice.model.TypeAndAnnouncement
2324
import com.mapbox.navigation.voice.options.MapboxSpeechApiOptions
2425
import java.io.InputStream

voice/src/test/java/com/mapbox/navigation/voice/api/MapboxSpeechProviderTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import com.mapbox.navigation.ui.utils.internal.resource.ResourceLoadRequest
1919
import com.mapbox.navigation.utils.internal.InternalJobControlFactory
2020
import com.mapbox.navigation.utils.internal.JobControl
2121
import com.mapbox.navigation.utils.internal.ThreadController
22+
import com.mapbox.navigation.utils.internal.UrlUtils
2223
import com.mapbox.navigation.voice.options.MapboxSpeechApiOptions
2324
import com.mapbox.navigation.voice.options.VoiceGender
2425
import com.mapbox.navigation.voice.testutils.Fixtures

0 commit comments

Comments
 (0)