Add ImplicitMSTestUsings property to control MSTest implicit usings #6313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3452ae to
c44d51b
Compare
The addition of this namespace to Implicit Usings is causing us problems because we make use of the System.ComponentModel.DescriptionAttribute in more places. * Add ImplicitMSTestUsings property to control MSTest implicit usings * Add comprehensive tests for ImplicitMSTestUsings property
I'm quite curious about this. What are you using |
Youssef1313
reviewed
Aug 6, 2025
| @@ -31,7 +31,7 @@ | |||
| Ensure feature is available and user hasn't opted-out from it. | |||
| See https://github.com/dotnet/sdk/blob/f9fdf2c7d94bc86dc443e5a9ffecbd1962b1d85d/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.CSharp.props#L26-L34 | |||
| --> | |||
| <ItemGroup Condition=" '$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable' "> | |||
| <ItemGroup Condition="('$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable') And ('$(ImplicitMSTestUsings)' == '' Or '$(ImplicitMSTestUsings)' == 'true' Or '$(ImplicitMSTestUsings)' == 'enable')"> | |||
There was a problem hiding this comment.
I would simply go with DisableMSTestImplicitUsings and only check whether it's set to true.
Suggested change
| <ItemGroup Condition="('$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable') And ('$(ImplicitMSTestUsings)' == '' Or '$(ImplicitMSTestUsings)' == 'true' Or '$(ImplicitMSTestUsings)' == 'enable')"> | |
| <ItemGroup Condition="('$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable') And '$(DisableMSTestImplicitUsings)' != 'true'"> |
Youssef1313
reviewed
Aug 6, 2025
| @@ -25,7 +25,7 @@ | |||
| Ensure feature is available and user hasn't opted-out from it. | |||
| See https://github.com/dotnet/sdk/blob/f9fdf2c7d94bc86dc443e5a9ffecbd1962b1d85d/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.CSharp.props#L26-L34 | |||
| --> | |||
| <ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'"> | |||
| <ItemGroup Condition="('$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable') And ('$(ImplicitMSTestUsings)' == '' Or '$(ImplicitMSTestUsings)' == 'true' Or '$(ImplicitMSTestUsings)' == 'enable')"> | |||
There was a problem hiding this comment.
Same suggestion applies here
Youssef1313
reviewed
Aug 6, 2025
| @@ -5,7 +5,7 @@ | |||
| Ensure feature is available and user hasn't opted-out from it. | |||
| See https://github.com/dotnet/sdk/blob/f9fdf2c7d94bc86dc443e5a9ffecbd1962b1d85d/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.CSharp.props#L26-L34 | |||
| --> | |||
| <ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'"> | |||
| <ItemGroup Condition="('$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable') And ('$(ImplicitMSTestUsings)' == '' Or '$(ImplicitMSTestUsings)' == 'true' Or '$(ImplicitMSTestUsings)' == 'enable')"> | |||
There was a problem hiding this comment.
Same suggestion applies here
Youssef1313
reviewed
Aug 6, 2025
There was a problem hiding this comment.
I'm also curious, wouldn't the following be a reasonable workaround for you?
<ItemGroup>
<Using Remove="Microsoft.VisualStudio.TestTools.UnitTesting" />
</ItemGroup>Maybe we should move our <Using Include="..." /> to be in props instead of targets so that it's defined early enough that you can easily remove it later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of this namespace to Implicit Usings is causing us problems because we make use of the System.ComponentModel.DescriptionAttribute in more places.