fix range calculation in composeObject API (#1553)

balamurugana · web-flow · commit f80a7021d872 · 2024-06-14T09:03:17.000-07:00
Signed-off-by: Bala.FA &lt;bala@minio.io&gt;
diff --git a/api/src/main/java/io/minio/MinioAsyncClient.java b/api/src/main/java/io/minio/MinioAsyncClient.java
@@ -769,15 +769,15 @@ public CompletableFuture<ObjectWriteResponse> composeObject(ComposeObjectArgs ar
                               while (size > 0) {
                                 partNumber++;
 
-                                long startBytes = offset;
-                                long endBytes = startBytes + ObjectWriteArgs.MAX_PART_SIZE;
-                                if (size < ObjectWriteArgs.MAX_PART_SIZE)
-                                  endBytes = startBytes + size;
+                                long length = size;
+                                if (length > ObjectWriteArgs.MAX_PART_SIZE) {
+                                  length = ObjectWriteArgs.MAX_PART_SIZE;
+                                }
+                                long endBytes = offset + length - 1;
 
                                 Multimap<String, String> headersCopy = newMultimap(headers);
                                 headersCopy.put(
-                                    "x-amz-copy-source-range",
-                                    "bytes=" + startBytes + "-" + endBytes);
+                                    "x-amz-copy-source-range", "bytes=" + offset + "-" + endBytes);
 
                                 final int partNum = partNumber;
                                 future =
@@ -801,8 +801,8 @@ public CompletableFuture<ObjectWriteResponse> composeObject(ComposeObjectArgs ar
                                             throw new CompletionException(e);
                                           }
                                         });
-                                offset = startBytes;
-                                size -= (endBytes - startBytes);
+                                offset += length;
+                                size -= length;
                               }
                             }
 
