Build all packages in 1 job

overlookmotel · overlookmotel · commit 35e48c67e0eb · 2025-08-02T10:22:34.000+01:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -145,17 +145,68 @@ jobs:
           pnpm run test-browser
           pnpm build-browser-bundle --npmDir npm-dir
 
-  # Sharded because these tests are slow
-  test-napi:
+  # NAPI tests are slow, so we shard them into multiple jobs.
+  # But we want to build all the packages together, so they share a single build cache.
+  #
+  # * `napi-build` - build all packages, and upload build files as an artifact.
+  # * In parallel:
+  #   * `napi-test` (sharded - 1 job per package)
+  #   * `napi-test-e2e`
+  # * `napi-cleanup` - deletes build files artifact
+  napi-build:
+    name: Build NAPI packages
+    runs-on: ubuntu-latest
+    steps:
+      - uses: taiki-e/checkout-action@b13d20b7cda4e2f325ef19895128f7ff735c0b3d # v1.3.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
+        id: filter
+        with:
+          predicate-quantifier: "every"
+          filters: |
+            src:
+              - '!crates/oxc_linter/**'
+              - '!crates/oxc_language_server/**'
+              - '!editors/**'
+      - uses: oxc-project/setup-rust@cd82e1efec7fef815e2c23d296756f31c7cdc03d # v1.0.0
+        if: steps.filter.outputs.src == 'true'
+        with:
+          cache-key: napi
+          save-cache: ${{ github.ref_name == 'main' }}
+      - uses: oxc-project/setup-node@f42e3bda950c7454575e78ee4eaac880a077700c # v1.0.0
+        if: steps.filter.outputs.src == 'true'
+      - name: Build
+        if: steps.filter.outputs.src == 'true'
+        run: |
+          rustup target add wasm32-wasip1-threads
+          pnpm run build-test
+      - name: Check no uncommitted files
+        if: steps.filter.outputs.src == 'true'
+        run: |
+          git diff --exit-code # Must commit everything
+      - name: Upload build files
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          if-no-files-found: error
+          name: napi
+          path: |
+            napi/minify/*.node
+            napi/oxlint2/dist/
+            napi/parser/*.node
+            napi/transform/*.node
+          retention-days: 1
+
+  napi-test:
     name: Test NAPI
     runs-on: ubuntu-latest
+    needs: napi-build
     strategy:
       fail-fast: true
       matrix:
         component:
+          - minify
           - oxlint2
           - parser
-          - playground
+          - transform
     steps:
       - uses: taiki-e/checkout-action@b13d20b7cda4e2f325ef19895128f7ff735c0b3d # v1.3.1
       - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
@@ -167,36 +218,28 @@ jobs:
               - '!crates/oxc_linter/**'
               - '!crates/oxc_language_server/**'
               - '!editors/**'
-      - uses: ./.github/actions/clone-submodules
-        if: steps.filter.outputs.src == 'true' && matrix.component == 'parser'
-      - uses: oxc-project/setup-rust@cd82e1efec7fef815e2c23d296756f31c7cdc03d # v1.0.0
+      - uses: oxc-project/setup-node@f42e3bda950c7454575e78ee4eaac880a077700c # v1.0.0
         if: steps.filter.outputs.src == 'true'
+      - name: Download build files
+        uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
         with:
-          cache-key: napi-${{ matrix.component }}
-          save-cache: ${{ github.ref_name == 'main' }}
-      - uses: oxc-project/setup-node@f42e3bda950c7454575e78ee4eaac880a077700c # v1.0.0
+          name: napi
+          pattern: napi/${{ matrix.component }}/**/*
+      # Submodules only needed for parser tests
+      - uses: ./.github/actions/clone-submodules
+        if: steps.filter.outputs.src == 'true' && matrix.component == 'parser'
+      - name: Run tests
         if: steps.filter.outputs.src == 'true'
-      - if: steps.filter.outputs.src == 'true'
-        name: Build
-        working-directory: napi/${{ matrix.component }}
-        run: |
-          rustup target add wasm32-wasip1-threads
-          pnpm run build-test
-      - if: steps.filter.outputs.src == 'true' && matrix.component != 'playground'
-        name: Run tests
         working-directory: napi/${{ matrix.component }}
         env:
           RUN_RAW_TESTS: "true"
         run: |
           pnpm run test
-      - if: steps.filter.outputs.src == 'true'
-        run: |
-          git diff --exit-code # Must commit everything
 
-  # Includes transformer and minifier
-  test-napi-e2e:
+  napi-test-e2e:
     name: Test NAPI (e2e)
     runs-on: ubuntu-latest
+    needs: napi-build
     steps:
       - uses: taiki-e/checkout-action@b13d20b7cda4e2f325ef19895128f7ff735c0b3d # v1.3.1
       - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
@@ -208,46 +251,33 @@ jobs:
               - '!crates/oxc_linter/**'
               - '!crates/oxc_language_server/**'
               - '!editors/**'
-      - uses: oxc-project/setup-rust@cd82e1efec7fef815e2c23d296756f31c7cdc03d # v1.0.0
+      - uses: oxc-project/setup-node@f42e3bda950c7454575e78ee4eaac880a077700c # v1.0.0
         if: steps.filter.outputs.src == 'true'
+      - name: Download build files
+        uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
         with:
-          cache-key: napi-e2e
-          save-cache: ${{ github.ref_name == 'main' }}
-      - uses: oxc-project/setup-node@f42e3bda950c7454575e78ee4eaac880a077700c # v1.0.0
+          name: napi
+          pattern: napi/**/*.node
+      - name: Install NPM packages
         if: steps.filter.outputs.src == 'true'
-      - if: steps.filter.outputs.src == 'true'
-        name: Install wasm32-wasip1-threads
-        run: |
-          rustup target add wasm32-wasip1-threads
-      - if: steps.filter.outputs.src == 'true'
-        name: Build transformer
-        working-directory: napi/transform
-        run: |
-          pnpm run build-test
-      - if: steps.filter.outputs.src == 'true'
-        name: Run transformer tests
-        working-directory: napi/transform
-        run: |
-          pnpm run test
-      - if: steps.filter.outputs.src == 'true'
-        name: Build minifier
-        working-directory: napi/minify
-        run: |
-          pnpm run build-test
-      - if: steps.filter.outputs.src == 'true'
-        name: Run minifier tests
-        working-directory: napi/minify
-        run: |
-          pnpm run test
-      - if: steps.filter.outputs.src == 'true'
-        name: Run e2e tests
         working-directory: tasks/e2e
         run: |
           pnpm install --frozen-lockfile
-          pnpm run test
-      - if: steps.filter.outputs.src == 'true'
+      - name: Run tests
+        if: steps.filter.outputs.src == 'true'
+        working-directory: tasks/e2e
         run: |
-          git diff --exit-code # Must commit everything
+          pnpm run test
+
+  napi-cleanup:
+    name: Delete NAPI build artifacts
+    runs-on: ubuntu-latest
+    needs: [napi-test, napi-test-e2e]
+    steps:
+      - uses: geekyeggo/delete-artifact@vf275313e70c08f6120db482d7a6b98377786765b # v5.1.0
+        with:
+          name: napi
+          failOnError: false
 
   typos:
     name: Spell Check
