Port proto_library tests to Starlark

comius · copybara-github · commit 5bb045825291 · 2025-08-08T04:17:59.000-07:00
Upgrade bazel_features. Flipping experimental flag in a test is only supported on Bazel 8.
Upgrade rules_testing to 0.9.0. basename() is only available with latest release.

test_descriptor_set_output_strict_deps_default was dropped.

PiperOrigin-RevId: 792567553
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -36,7 +36,7 @@ bazel_dep(name = "zlib", version = "1.3.1.bcr.5")
 #endif // PROTO2_OPENSOURCE
 
 # other dependencies
-bazel_dep(name = "bazel_features", version = "1.23.0", repo_name = "proto_bazel_features")
+bazel_dep(name = "bazel_features", version = "1.33.0", repo_name = "proto_bazel_features")
 bazel_dep(name = "bazel_skylib", version = "1.7.1")
 bazel_dep(name = "jsoncpp", version = "1.9.6")
 bazel_dep(name = "rules_java", version = "8.6.1")
@@ -250,7 +250,7 @@ use_repo(protobuf_maven_dev, "protobuf_maven_dev")
 
 bazel_dep(name = "googletest", version = "1.15.2", dev_dependency = True)
 bazel_dep(name = "rules_buf", version = "0.3.0", dev_dependency = True)
-bazel_dep(name = "rules_testing", version = "0.8.0", dev_dependency = True)
+bazel_dep(name = "rules_testing", version = "0.9.0", dev_dependency = True)
 bazel_dep(
     name = "abseil-py",
     version = "2.1.0",
diff --git a/WORKSPACE b/WORKSPACE
@@ -311,9 +311,9 @@ protobuf_v25_deps()
 
 http_archive(
     name = "rules_testing",
-    sha256 = "89feaf18d6e2fc07ed7e34510058fc8d48e45e6d2ff8a817a718e8c8e4bcda0e",
-    strip_prefix = "rules_testing-0.8.0",
-    url = "https://github.com/bazelbuild/rules_testing/releases/download/v0.8.0/rules_testing-v0.8.0.tar.gz",
+    sha256 = "281b69eed71e2b95cefc284ee5a1a9f7c5088141b58f2508be910eb22f13b986",
+    strip_prefix = "rules_testing-0.9.0",
+    url = "https://github.com/bazelbuild/rules_testing/releases/download/v0.9.0/rules_testing-v0.9.0.tar.gz",
 )
 
 # For checking breaking changes to well-known types from the previous release version.
diff --git a/bazel/private/proto_bazel_features.bzl b/bazel/private/proto_bazel_features.bzl
@@ -14,6 +14,9 @@ _PROTO_BAZEL_FEATURES = """bazel_features = struct(
   proto = struct(
     starlark_proto_info = {starlark_proto_info},
   ),
+  rules = struct(
+    analysis_tests_can_transition_on_experimental_incompatible_flags = {analysis_tests_can_transition_on_experimental_incompatible_flags},
+  ),
   globals = struct(
     PackageSpecificationInfo = {PackageSpecificationInfo},
     ProtoInfo = getattr(getattr(native, 'legacy_globals', None), 'ProtoInfo', {ProtoInfo}),
@@ -53,6 +56,8 @@ exports_files(["features.bzl"])
         protobuf_on_allowlist = repr(protobuf_on_allowlist),
         ProtoInfo = ProtoInfo,
         cc_proto_aspect = cc_proto_aspect,
+        analysis_tests_can_transition_on_experimental_incompatible_flags =
+            "True" if major_version_int > 8 or (major_version_int == 8 and minor_version_int >= 2) else "False",
     ))
 
 proto_bazel_features = repository_rule(
diff --git a/bazel/tests/BUILD b/bazel/tests/BUILD
@@ -1,3 +1,4 @@
+load(":bazel_proto_library_tests.bzl", "bazel_proto_library_test_suite")
 load(":java_proto_library_tests.bzl", "java_proto_library_test_suite")
 load(":proto_common_check_collocated_tests.bzl", "proto_common_check_collocated_test_suite")
 load(":proto_common_compile_tests.bzl", "proto_common_compile_test_suite")
@@ -14,4 +15,6 @@ proto_common_declare_generated_files_test_suite(name = "proto_common_declare_gen
 
 proto_common_check_collocated_test_suite(name = "proto_common_check_collocated_test_suite")
 
+bazel_proto_library_test_suite(name = "bazel_proto_library_test_suite")
+
 java_proto_library_test_suite(name = "java_proto_library_test_suite")
diff --git a/bazel/tests/bazel_proto_library_tests.bzl b/bazel/tests/bazel_proto_library_tests.bzl
diff --git a/protobuf_deps.bzl b/protobuf_deps.bzl
