Remove has_presence condition on updating cached_has_bits in serialize.

ClaytonKnittel · copybara-github · commit 99e79db03f5b · 2025-08-06T16:54:58.000-07:00
Implicit presence fields use hasbits, so there is no reason we shouldn't update cached_has_bits for them.

PiperOrigin-RevId: 791897325
diff --git a/src/google/protobuf/compiler/cpp/message.cc b/src/google/protobuf/compiler/cpp/message.cc
@@ -4856,7 +4856,7 @@ void MessageGenerator::GenerateSerializeWithCachedSizesBody(io::Printer* p) {
         v_.push_back(field);
       } else {
         // TODO: Defer non-oneof fields similarly to oneof fields.
-        if (HasHasbit(field, options_) && field->has_presence()) {
+        if (HasHasbit(field, options_)) {
           // We speculatively load the entire _has_bits_[index] contents, even
           // if it is for only one field.  Deferring non-oneof emitting would
           // allow us to determine whether this is going to be useful.
