add time dimension to metrics_time_range resolver cache key (#7728)

pjain1 · web-flow · commit c48f54ad1969 · 2025-08-05T22:45:29.000+05:30
diff --git a/runtime/resolvers/metricsview_time_range.go b/runtime/resolvers/metricsview_time_range.go
@@ -100,7 +100,12 @@ func (r *metricsViewTimeRangeResolver) Close() error {
 }
 
 func (r *metricsViewTimeRangeResolver) CacheKey(ctx context.Context) ([]byte, bool, error) {
-	return cacheKeyForMetricsView(ctx, r.runtime, r.instanceID, r.mvName, r.args.Priority)
+	key, ok, err := cacheKeyForMetricsView(ctx, r.runtime, r.instanceID, r.mvName, r.args.Priority)
+	if err != nil {
+		return nil, false, err
+	}
+	key = append(key, []byte(r.args.TimeDimension)...)
+	return key, ok, nil
 }
 
 func (r *metricsViewTimeRangeResolver) Refs() []*runtimev1.ResourceName {

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,12 @@ func (r *metricsViewTimeRangeResolver) Close() error {`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`func (r *metricsViewTimeRangeResolver) CacheKey(ctx context.Context) ([]byte, bool, error) {`
`103`		`- return cacheKeyForMetricsView(ctx, r.runtime, r.instanceID, r.mvName, r.args.Priority)`
	`103`	`+ key, ok, err := cacheKeyForMetricsView(ctx, r.runtime, r.instanceID, r.mvName, r.args.Priority)`
	`104`	`+ if err != nil {`
	`105`	`+ return nil, false, err`
	`106`	`+ }`
	`107`	`+ key = append(key, []byte(r.args.TimeDimension)...)`
	`108`	`+ return key, ok, nil`
`104`	`109`	`}`
`105`	`110`
`106`	`111`	`func (r metricsViewTimeRangeResolver) Refs() []runtimev1.ResourceName {`