Skip to content

PLAT-28 : Disable enable_external_access for duckdb for finer controls #7712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

PLAT-28 : Disable enable_external_access for duckdb for finer controls #7712

wants to merge 3 commits into from

Conversation

k-anshul
Copy link
Member

@k-anshul k-anshul commented Aug 1, 2025 •
edited
Loading

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Aug 1, 2025
@k-anshul k-anshul requested a review from begelundmuller August 1, 2025 12:10
k-anshul
k-anshul commented Aug 1, 2025
View reviewed changes
runtime/drivers/duckdb/duckdb.go
return err
}

// Find the instance dir for the data dir
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal but at present there is no way to get instance dir from storage. The storage driver does not have concept of instance.

@k-anshul
Copy link
Member Author

k-anshul commented Aug 1, 2025

Please hold review on this. Looks like there are edge cases in our test setups that we need to handle.

@k-anshul k-anshul marked this pull request as draft August 1, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller Awaiting requested review from begelundmuller

At least 1 approving review is required to merge this pull request.

Assignees

@k-anshul k-anshul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@k-anshul