Core: remove pending class from fields with an aborted request (jquery-validation#2436)

bidord · web-flow · commit 98fbc5f4287b · 2022-07-17T12:21:36.000+01:00
Ref jquery-validation#2434 Ref jquery-validation#2435 Co-authored-by: Sylvain Monné <sylvain@monne.me>
diff --git a/src/core.js b/src/core.js
@@ -1152,6 +1152,7 @@ $.extend( $.validator, {
 				}
 
 				delete this.pending[ element.name ];
+				$( element ).removeClass( this.settings.pendingClass );
 			}
 		},
 
diff --git a/test/methods.js b/test/methods.js
@@ -822,11 +822,19 @@ QUnit.test( "Fix #2434: race condition in remote validation rules", function( as
 
 	e.val( "Peter" );
 	v.element( e );
+	assert.equal( e.hasClass( "error" ), false, "Field 'username' should not have the error class" );
+	assert.equal( e.hasClass( "pending" ), true, "field 'username' should have the pending class" );
 
 	e.val( "" );
 	v.element( e );
+	assert.equal( v.errorList[ 0 ].message, "This field is required." );
+	assert.equal( e.hasClass( "error" ), true, "Field 'username' should have the error class" );
+	assert.equal( e.hasClass( "pending" ), false, "field 'username' should not have the pending class" );
+
 	setTimeout( function() {
 		assert.equal( v.errorList[ 0 ].message, "This field is required." );
+		assert.equal( e.hasClass( "error" ), true, "Field 'username' should have the error class" );
+		assert.equal( e.hasClass( "pending" ), false, "field 'username' should not have the pending class" );
 		done1();
 	} );
 } );

Original file line number	Diff line number	Diff line change
`@@ -1152,6 +1152,7 @@ $.extend( $.validator, {`
`1152`	`1152`	`}`
`1153`	`1153`
`1154`	`1154`	`delete this.pending[ element.name ];`
	`1155`	`+ $( element ).removeClass( this.settings.pendingClass );`
`1155`	`1156`	`}`
`1156`	`1157`	`},`
`1157`	`1158`