[Fix #334] Fix minitest extension for the cop generator

rafaelfranca · rafaelfranca · commit d6256f47abe8 · 2025-05-12T22:38:50.000Z
Instead of reopening the Generator class in a file with the same name of the Generator class in the main rubocop gem, we are now defining a module that get included in the Generator class, defined in a different file path, specific for this minitest plugin. This allows rubocop plugins that want to use minitest to test their code to be able to generate their own cops using the minitest extension. Fixes #334.
diff --git a/Rakefile b/Rakefile
@@ -17,7 +17,7 @@ end
 
 require 'rubocop/rake_task'
 require 'rake/testtask'
-require_relative 'lib/rubocop/cop/generator'
+require 'rubocop/cop/minitest_generator'
 
 # JRuby and Windows don't support fork, so we can't use minitest-queue.
 if RUBY_ENGINE == 'jruby' || RuboCop::Platform.windows?
diff --git a/changelog/fix_fix_minitest_extension_for_the_cop.md b/changelog/fix_fix_minitest_extension_for_the_cop.md
@@ -0,0 +1 @@
+* [#334](https://github.com/rubocop/rubocop-minitest/issues/334): Fix minitest extension for the cop generator. ([@rafaelfranca][])
diff --git a/lib/rubocop/cop/minitest_generator.rb b/lib/rubocop/cop/minitest_generator.rb
@@ -1,12 +1,14 @@
 # frozen_string_literal: true
 
+require 'rubocop/cop/generator'
+
 module RuboCop
   module Cop
     # Source and test generator for new cops
     #
     # This generator will take a cop name and generate a source file
     # and test file when given a valid qualified cop name.
-    class Generator
+    module MinitestGenerator
       TEST_TEMPLATE = <<~TEST
         # frozen_string_literal: true
 
@@ -48,3 +50,5 @@ def generated_test
     end
   end
 end
+
+RuboCop::Cop::Generator.include(RuboCop::Cop::MinitestGenerator)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+* [#334](https://github.com/rubocop/rubocop-minitest/issues/334): Fix minitest extension for the cop generator. ([@rafaelfranca][])`