Skip to content

Commit 4b14015

Browse files
bquorningbquorning
authored
Merge pull request #2043 from rubocop/release
Release v3.5.0
2 parents dac4256 + 6dafd48 commit 4b14015

File tree

8 files changed

+39
-15
lines changed

8 files changed

+39
-15
lines changed

‎.rubocop.yml

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,6 @@ AllCops:
1616
- 'tmp/**/*'
1717
- 'spec/smoke_tests/**/*.rb'
1818

19-
# Enable when we require rubocop >= 1.71.1 or rubocop-ast >= 1.38.0
20-
InternalAffairs/NodePatternGroups:
21-
Enabled: false
22-
23-
# Enable when we require rubocop >= 1.71.1 or rubocop-ast >= 1.38.0
24-
InternalAffairs/NodeTypeMultiplePredicates:
25-
Enabled: false
26-
2719
InternalAffairs/OnSendWithoutOnCSend:
2820
Enabled: false
2921

@@ -143,7 +135,7 @@ Style/NumberedParameters:
143135
Style/RequireOrder:
144136
Enabled: true
145137

146-
# Enable RuboCop's pending cops up to v1.71
138+
# Enable RuboCop's pending cops up to v1.72
147139

148140
Gemspec/AddRuntimeDependency: {Enabled: true}
149141
Gemspec/DeprecatedAttributeAssignment: {Enabled: true}
@@ -159,6 +151,7 @@ Lint/AmbiguousRange: {Enabled: true}
159151
Lint/ArrayLiteralInRegexp: {Enabled: true}
160152
Lint/ConstantOverwrittenInRescue: {Enabled: true}
161153
Lint/ConstantReassignment: {Enabled: true}
154+
Lint/CopDirectiveSyntax: {Enabled: true}
162155
Lint/DeprecatedConstants: {Enabled: true}
163156
Lint/DuplicateBranch: {Enabled: true}
164157
Lint/DuplicateMagicComment: {Enabled: true}
@@ -181,16 +174,19 @@ Lint/NumericOperationWithConstantResult: {Enabled: true}
181174
Lint/OrAssignmentToConstant: {Enabled: true}
182175
Lint/RedundantDirGlobSort: {Enabled: true}
183176
Lint/RedundantRegexpQuantifiers: {Enabled: true}
177+
Lint/RedundantTypeConversion: {Enabled: true}
184178
Lint/RefinementImportMethods: {Enabled: true}
185179
Lint/RequireRangeParentheses: {Enabled: true}
186180
Lint/RequireRelativeSelfPath: {Enabled: true}
187181
Lint/SharedMutableDefault: {Enabled: true}
182+
Lint/SuppressedExceptionInNumberConversion: {Enabled: true}
188183
Lint/SymbolConversion: {Enabled: true}
189184
Lint/ToEnumArguments: {Enabled: true}
190185
Lint/TripleQuotes: {Enabled: true}
191186
Lint/UnescapedBracketInRegexp: {Enabled: true}
192187
Lint/UnexpectedBlockArity: {Enabled: true}
193188
Lint/UnmodifiedReduceAccumulator: {Enabled: true}
189+
Lint/UselessConstantScoping: {Enabled: true}
194190
Lint/UselessDefined: {Enabled: true}
195191
Lint/UselessNumericOperation: {Enabled: true}
196192
Lint/UselessRescue: {Enabled: true}
@@ -250,6 +246,7 @@ Style/RedundantCurrentDirectoryInPath: {Enabled: true}
250246
Style/RedundantDoubleSplatHashBraces: {Enabled: true}
251247
Style/RedundantEach: {Enabled: true}
252248
Style/RedundantFilterChain: {Enabled: true}
249+
Style/RedundantFormat: {Enabled: true}
253250
Style/RedundantHeredocDelimiterQuotes: {Enabled: true}
254251
Style/RedundantInitialize: {Enabled: true}
255252
Style/RedundantInterpolationUnfreeze: {Enabled: true}
@@ -269,7 +266,7 @@ Style/SuperWithArgsParentheses: {Enabled: true}
269266
Style/SwapValues: {Enabled: true}
270267
Style/YAMLFileRead: {Enabled: true}
271268

272-
# Enable RuboCop Performance's pending cops up to v1.23
269+
# Enable RuboCop Performance's pending cops up to v1.24
273270

274271
Performance/AncestorsInclude: {Enabled: true}
275272
Performance/BigDecimalWithNumericArgument: {Enabled: true}
@@ -291,3 +288,4 @@ Performance/StringBytesize: {Enabled: true}
291288
Performance/StringIdentifierArgument: {Enabled: true}
292289
Performance/StringInclude: {Enabled: true}
293290
Performance/Sum: {Enabled: true}
291+
Performance/ZipWithoutBlock: {Enabled: true}

‎.rubocop_todo.yml

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,32 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
3-
# using RuboCop version 1.71.2.
3+
# using RuboCop version 1.72.1.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
77
# versions of RuboCop, may require this file to be generated again.
88

9+
# This cop supports safe autocorrection (--autocorrect).
10+
InternalAffairs/NodePatternGroups:
11+
Exclude:
12+
- 'lib/rubocop/cop/rspec/described_class.rb'
13+
- 'lib/rubocop/cop/rspec/described_class_module_wrapping.rb'
14+
- 'lib/rubocop/cop/rspec/hook_argument.rb'
15+
- 'lib/rubocop/cop/rspec/hooks_before_examples.rb'
16+
- 'lib/rubocop/cop/rspec/no_expectation_example.rb'
17+
- 'lib/rubocop/cop/rspec/pending_without_reason.rb'
18+
- 'lib/rubocop/cop/rspec/redundant_around.rb'
19+
- 'lib/rubocop/rspec/language.rb'
20+
21+
# This cop supports safe autocorrection (--autocorrect).
22+
InternalAffairs/NodeTypeMultiplePredicates:
23+
Exclude:
24+
- 'lib/rubocop/cop/rspec/empty_example_group.rb'
25+
- 'lib/rubocop/cop/rspec/predicate_matcher.rb'
26+
- 'lib/rubocop/cop/rspec/receive_messages.rb'
27+
- 'lib/rubocop/cop/rspec/variable_definition.rb'
28+
- 'lib/rubocop/cop/rspec/variable_name.rb'
29+
930
Rake/MethodDefinitionInTask:
1031
Exclude:
1132
- 'tasks/cut_release.rake'

‎CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## Master (Unreleased)
44

5+
## 3.5.0 (2025-02-16)
6+
57
- Don't let `RSpec/PredicateMatcher` replace `respond_to?` with two arguments with the RSpec `respond_to` matcher. ([@bquorning])
68
- Fix `RSpec/PredicateMatcher` support for `eql` and `equal` matchers. ([@bquorning])
79
- Pluginfy RuboCop RSpec. ([@koic])

‎Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ gem 'bump'
88
gem 'rack'
99
gem 'rake'
1010
gem 'rspec', '~> 3.11'
11-
gem 'rubocop-performance', '~> 1.7'
12-
gem 'rubocop-rake', '~> 0.6'
11+
gem 'rubocop-performance', '~> 1.24'
12+
gem 'rubocop-rake', '~> 0.7'
1313
gem 'simplecov', '>= 0.19'
1414
gem 'yard'
1515

‎docs/antora.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: rubocop-rspec
22
title: RuboCop RSpec
3-
version: ~
3+
version: '3.5'
44
nav:
55
- modules/ROOT/nav.adoc

‎lib/rubocop/cop/rspec/indexed_let.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
7474
private
7575

7676
SUFFIX_INDEX_REGEX = /_?\d+$/.freeze
77+
private_constant :SUFFIX_INDEX_REGEX
7778
INDEX_REGEX = /\d+/.freeze
79+
private_constant :INDEX_REGEX
7880

7981
def filter_indexed_lets(candidates)
8082
candidates

‎lib/rubocop/cop/rspec/return_from_stub.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ def heredoc?
162162
end
163163

164164
NULL_BLOCK_BODY = Struct.new(:loc, :source).new(nil, 'nil')
165+
private_constant :NULL_BLOCK_BODY
165166
end
166167
end
167168
end

‎lib/rubocop/rspec/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module RuboCop
44
module RSpec
55
# Version information for the RSpec RuboCop plugin.
66
module Version
7-
STRING = '3.4.0'
7+
STRING = '3.5.0'
88
end
99
end
1010
end

0 commit comments

Comments
 (0)