Merge pull request #5089 from sjrd/fix-striptrailingzeros

gzm0 · web-flow · commit 9ca3cd82098a · 2024-12-17T09:21:31.000+01:00
Fix #5085: Zero.stripTrailingZeros() returns BigDecimal.ZERO.
diff --git a/javalib/src/main/scala/java/math/BigDecimal.scala b/javalib/src/main/scala/java/math/BigDecimal.scala
@@ -1226,9 +1226,8 @@ class BigDecimal() extends Number with Comparable[BigDecimal] {
 
   def stripTrailingZeros(): BigDecimal = {
     if (isZero) {
-      // Preserve RI compatibility, so BigDecimal.equals (which checks
-      // value *and* scale) continues to work.
-      this
+      // As specified by the JavaDoc, we must return BigDecimal.ZERO, which has a scale of 0
+      BigDecimal.ZERO
     } else {
       val lastPow = BigTenPows.length - 1
 
diff --git a/test-suite/shared/src/test/scala/org/scalajs/testsuite/javalib/math/BigDecimalScaleOperationsTest.scala b/test-suite/shared/src/test/scala/org/scalajs/testsuite/javalib/math/BigDecimalScaleOperationsTest.scala
@@ -287,4 +287,8 @@ class  BigDecimalScaleOperationsTest {
     val prec = aNumber.precision()
     assertEquals(prec, 68)
   }
+
+  @Test def testStripTrailingZeros(): Unit = {
+    assertEquals(0, java.math.BigDecimal.valueOf(0, 9).stripTrailingZeros().scale())
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -287,4 +287,8 @@ class BigDecimalScaleOperationsTest {`
`287`	`287`	`val prec = aNumber.precision()`
`288`	`288`	`assertEquals(prec, 68)`
`289`	`289`	`}`
	`290`	`+`
	`291`	`+ @Test def testStripTrailingZeros(): Unit = {`
	`292`	`+ assertEquals(0, java.math.BigDecimal.valueOf(0, 9).stripTrailingZeros().scale())`
	`293`	`+ }`
`290`	`294`	`}`