Fix #699: properly deprecated TimeSeriesRegressor.partial_fit method #738
+418
−416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the example to use the new update method instead of the deprecated partial_fit for TimeSeriesRegressor with ENBPI. Adjusted documentation to clarify that update internally calls partial_fit when method='enbpi', and that observed improvements are due to partial_fit's behavior.
Replaces references to `partial_fit` with `update` in the notebook and clarifies the internal behavior of `update`.
Removes extra spaces in the docstring of plot_timeseries_enbpi.py for improved readability and consistency.
|
Hello @kleeena, thank you for your contribution. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Valentin-Laurent
requested changes
Aug 10, 2025
There was a problem hiding this comment.
@kleeena Actually managed to find some time for a review.
Can you please mention in the existing deprecation warning that the method will be removed in v1.2 ?
| ``update`` at every step, following [6]. Since ``update`` internally calls the | ||
| now-deprecated ``partial_fit`` method when ``method='enbpi'``, | ||
| the observed improved coverage and narrower PIs | ||
| are due to the underlying behavior of ``partial_fit``. |
There was a problem hiding this comment.
Let's not mention partial_fit at all in this part, now that the method is only internal.
For the legend of the graph below as well.
To be honest, I'm not sure about the correctness of what's being demonstrated here, but that's another problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR address the issue of TimeSeriesRegressor.partial_method being present by replacing it TimeSeriesRegressor.update in accordance to the
methodattribute, in the following files of the documentation:plot_timeseries_enbpi.pyts-changepoint.ipynbFixes #699
Type of change
Please remove options that are irrelevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
make lintmake type-checkmake testsmake coveragemake docmake doctest