Add MouseEvent types for event handlers (#3556)

not-matt · Hugos68 · web-flow · commit 16719d87c217 · 2025-05-22T10:39:18.000-05:00
Co-authored-by: Hugo Korte &lt;63101006+Hugos68@users.noreply.github.com&gt;
diff --git a/packages/skeleton-svelte/src/components/Modal/types.ts b/packages/skeleton-svelte/src/components/Modal/types.ts
@@ -69,5 +69,5 @@ export interface ModalProps extends Omit<dialog.Props, 'id'> {
 
 	// Events ---
 	/** Handle the dialog button click event. */
-	onclick?: () => void;
+	onclick?: HTMLButtonAttributes['onclick'];
 }
diff --git a/packages/skeleton-svelte/src/components/Popover/types.ts b/packages/skeleton-svelte/src/components/Popover/types.ts
@@ -53,5 +53,5 @@ export interface PopoverProps extends Omit<popover.Props, 'id'> {
 
 	// Events ---
 	/** Handle the popover button click event. */
-	onclick?: () => void;
+	onclick?: HTMLButtonAttributes['onclick'];
 }
diff --git a/packages/skeleton-svelte/src/components/Tooltip/types.ts b/packages/skeleton-svelte/src/components/Tooltip/types.ts
@@ -53,7 +53,7 @@ export interface TooltipProps extends Omit<tooltip.Props, 'id'> {
 
 	// Events ---
 	/** Handle the tooltip button hover event. */
-	onmouseover?: () => void;
+	onmouseover?: HTMLButtonAttributes['onmouseover'];
 	/** Handle the tooltip button click event. */
-	onclick?: () => void;
+	onclick?: HTMLButtonAttributes['onclick'];
 }

Original file line number	Diff line number	Diff line change
`@@ -69,5 +69,5 @@ export interface ModalProps extends Omit<dialog.Props, 'id'> {`
`69`	`69`
`70`	`70`	`// Events ---`
`71`	`71`	`/** Handle the dialog button click event. */`
`72`		`- onclick?: () => void;`
	`72`	`+ onclick?: HTMLButtonAttributes['onclick'];`
`73`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,5 +53,5 @@ export interface PopoverProps extends Omit<popover.Props, 'id'> {`
`53`	`53`
`54`	`54`	`// Events ---`
`55`	`55`	`/** Handle the popover button click event. */`
`56`		`- onclick?: () => void;`
	`56`	`+ onclick?: HTMLButtonAttributes['onclick'];`
`57`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ export interface TooltipProps extends Omit<tooltip.Props, 'id'> {`
`53`	`53`
`54`	`54`	`// Events ---`
`55`	`55`	`/** Handle the tooltip button hover event. */`
`56`		`- onmouseover?: () => void;`
	`56`	`+ onmouseover?: HTMLButtonAttributes['onmouseover'];`
`57`	`57`	`/** Handle the tooltip button click event. */`
`58`		`- onclick?: () => void;`
	`58`	`+ onclick?: HTMLButtonAttributes['onclick'];`
`59`	`59`	`}`