Skip to content

Commit 92feac4

Browse files
NaokiM03endigo9740
andauthored
Remove unnecessary loop in preset.scss (#3593)
Co-authored-by: Chris Simmons <gundamx9740@gmail.com>
1 parent e81f9e4 commit 92feac4

File tree

2 files changed

+29
-27
lines changed

2 files changed

+29
-27
lines changed

.changeset/huge-olives-happen.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@skeletonlabs/skeleton": patch
3+
---
4+
5+
bugfix: Remove unnecessary loop in `preset.scss`
6+

packages/skeleton/src/optional/presets.scss

Lines changed: 23 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,18 @@
1313

1414
/* Generated */
1515
@each $name in constants.$color-names {
16-
@each $name in constants.$color-names {
17-
/* 500 */
18-
@utility preset-filled-#{$name}-500 {
19-
background-color: var(--color-#{$name}-500);
20-
color: var(--color-#{$name}-contrast-500);
21-
}
22-
/* Pairings 50-950 */
23-
@each $pairing in constants.$color-pairings {
24-
$light: list.nth($pairing, 1);
25-
$dark: list.nth($pairing, 2);
26-
@utility preset-filled-#{$name}-#{$light}-#{$dark} {
27-
background-color: var(--color-#{$name}-#{$light}-#{$dark});
28-
color: var(--color-#{$name}-contrast-#{$light}-#{$dark});
29-
}
16+
/* 500 */
17+
@utility preset-filled-#{$name}-500 {
18+
background-color: var(--color-#{$name}-500);
19+
color: var(--color-#{$name}-contrast-500);
20+
}
21+
/* Pairings 50-950 */
22+
@each $pairing in constants.$color-pairings {
23+
$light: list.nth($pairing, 1);
24+
$dark: list.nth($pairing, 2);
25+
@utility preset-filled-#{$name}-#{$light}-#{$dark} {
26+
background-color: var(--color-#{$name}-#{$light}-#{$dark});
27+
color: var(--color-#{$name}-contrast-#{$light}-#{$dark});
3028
}
3129
}
3230
}
@@ -56,20 +54,18 @@
5654

5755
/* Generated */
5856
@each $name in constants.$color-names {
59-
@each $name in constants.$color-names {
60-
/* 500 */
61-
@utility preset-outlined-#{$name}-500 {
57+
/* 500 */
58+
@utility preset-outlined-#{$name}-500 {
59+
border-width: 1px;
60+
border-color: var(--color-#{$name}-500);
61+
}
62+
/* Pairings 50-950 */
63+
@each $pairing in constants.$color-pairings {
64+
$light: list.nth($pairing, 1);
65+
$dark: list.nth($pairing, 2);
66+
@utility preset-outlined-#{$name}-#{$light}-#{$dark} {
6267
border-width: 1px;
63-
border-color: var(--color-#{$name}-500);
64-
}
65-
/* Pairings 50-950 */
66-
@each $pairing in constants.$color-pairings {
67-
$light: list.nth($pairing, 1);
68-
$dark: list.nth($pairing, 2);
69-
@utility preset-outlined-#{$name}-#{$light}-#{$dark} {
70-
border-width: 1px;
71-
border-color: var(--color-#{$name}-#{$light}-#{$dark});
72-
}
68+
border-color: var(--color-#{$name}-#{$light}-#{$dark});
7369
}
7470
}
7571
}

0 commit comments

Comments
 (0)