Skip to content

Commit b521920

Browse files
authored
Resolve small errors tripping up our CI process (#3584)
1 parent e4c76d6 commit b521920

File tree

6 files changed

+11
-3
lines changed

6 files changed

+11
-3
lines changed

.changeset/rare-dodos-swim.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@skeletonlabs/skeleton-svelte": patch
3+
---
4+
5+
bugfix: Resolve issue in Popover, Tooltip, and Modal types for missing import.

packages/skeleton-svelte/src/components/Modal/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { Snippet } from 'svelte';
22
import * as dialog from '@zag-js/dialog';
33
import type { FlyParams, FadeParams } from 'svelte/transition';
4+
import type { HTMLButtonAttributes } from 'svelte/elements';
45

56
export interface ModalProps extends Omit<dialog.Props, 'id'> {
67
// Base ---

packages/skeleton-svelte/src/components/Popover/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import type { Snippet } from 'svelte';
22
import * as popover from '@zag-js/popover';
3+
import type { HTMLButtonAttributes } from 'svelte/elements';
34

45
export interface PopoverProps extends Omit<popover.Props, 'id'> {
56
/** Enable display of the popover arrow. */

packages/skeleton-svelte/src/components/Tooltip/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import type { Snippet } from 'svelte';
22
import * as tooltip from '@zag-js/tooltip';
3+
import type { HTMLButtonAttributes } from 'svelte/elements';
34

45
export interface TooltipProps extends Omit<tooltip.Props, 'id'> {
56
/** Enable display of the popover arrow. */

sites/skeleton.dev/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
"@images/*": ["src/images/*"]
1515
}
1616
},
17-
"exclude": ["node_modules", "dist", "public/pagefind"]
17+
"exclude": ["node_modules", "dist", "public/pagefind", "./scripts/generate-schemas.ts"]
1818
}

sites/themes.skeleton.dev/src/lib/components/generator/Controls/ControlsColors.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@
127127
<input
128128
type="text"
129129
class="input"
130-
bind:value={settingsColors[getColorKey(color.value, shade)]}
130+
bind:value={settingsColors[getColorKey(color.value, shade.toString())]}
131131
onblur={() => genColorRamp(showAllShades, color.value)}
132132
/>
133133
</td>
@@ -137,7 +137,7 @@
137137
<input
138138
class="input"
139139
type="color"
140-
bind:value={settingsColors[getColorKey(color.value, shade)]}
140+
bind:value={settingsColors[getColorKey(color.value, shade.toString())]}
141141
oninput={() => genColorRamp(showAllShades, color.value)}
142142
/>
143143
</td>

0 commit comments

Comments
 (0)