-
-
Notifications
You must be signed in to change notification settings - Fork 984
Description
Describe the bug
Setting popover={true}
in your JSX will generate popover="true"
in the HTML. This sort of works in most browsers, but it is invalid and can cause Chrome (with SSR-generated HTML at least) and other tools to complain.
Per https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover, the only valid values for popover
are ""
(same as "auto"
) , "manual"
, "auto"
, and "hint"
(experimental) .
However, the TypeScript definitions for this attribute are boolean | "manual" | "auto" | undefined
, and setting it to a boolean gives you values of "true"
and "false"
instead of ""
or unsetting it.
Your Example Website or App
https://playground.solidjs.com/anonymous/1748d882-88b6-4aea-b8e2-c792e17c38ea
Steps to Reproduce the Bug or Issue
Set popover={true}
, popover={false}
, or just popover
as a JSX attribute.
Expected behavior
As a developer, I expect:
popover={true}
andpopover
to generatepopover=""
or justpopover
in the HTML.popover={false}
to unset the attributepopover=""
to validate with TypeScript.
Screenshots or Videos
No response
Platform
- OS: macOS
- Browser: Chrome
- Version: 133.0.6943.127
Additional context
No response