optimize in_array calls

gharlan · nicolas-grekas · commit 9d273d604658 · 2025-07-15T11:40:20.000+02:00
diff --git a/Parser/Handler/StringHandler.php b/Parser/Handler/StringHandler.php
@@ -41,7 +41,7 @@ public function handle(Reader $reader, TokenStream $stream): bool
     {
         $quote = $reader->getSubstring(1);
 
-        if (!\in_array($quote, ["'", '"'])) {
+        if (!\in_array($quote, ["'", '"'], true)) {
             return false;
         }
 
diff --git a/Parser/Parser.php b/Parser/Parser.php
@@ -190,7 +190,7 @@ private function parseSimpleSelector(TokenStream $stream, bool $insideNegation =
                 }
 
                 $identifier = $stream->getNextIdentifier();
-                if (\in_array(strtolower($identifier), ['first-line', 'first-letter', 'before', 'after'])) {
+                if (\in_array(strtolower($identifier), ['first-line', 'first-letter', 'before', 'after'], true)) {
                     // Special case: CSS 2.1 pseudo-elements can have a single ':'.
                     // Any new pseudo-element must have two.
                     $pseudoElement = $identifier;

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function handle(Reader $reader, TokenStream $stream): bool`
`41`	`41`	`{`
`42`	`42`	`$quote = $reader->getSubstring(1);`
`43`	`43`
`44`		`- if (!\in_array($quote, ["'", '"'])) {`
	`44`	`+ if (!\in_array($quote, ["'", '"'], true)) {`
`45`	`45`	`return false;`
`46`	`46`	`}`
`47`	`47`
Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ private function parseSimpleSelector(TokenStream $stream, bool $insideNegation =`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`$identifier = $stream->getNextIdentifier();`
`193`		`- if (\in_array(strtolower($identifier), ['first-line', 'first-letter', 'before', 'after'])) {`
	`193`	`+ if (\in_array(strtolower($identifier), ['first-line', 'first-letter', 'before', 'after'], true)) {`
`194`	`194`	`// Special case: CSS 2.1 pseudo-elements can have a single ':'.`
`195`	`195`	`// Any new pseudo-element must have two.`
`196`	`196`	`$pseudoElement = $identifier;`