Remove deadcode after the bump to PHP >= 8.4

nicolas-grekas · nicolas-grekas · commit 793b31296161 · 2025-06-04T12:38:30.000+02:00
diff --git a/ByteString.php b/ByteString.php
@@ -56,38 +56,7 @@ public static function fromRandom(int $length = 16, ?string $alphabet = null): s
             throw new InvalidArgumentException('The length of the alphabet must in the [2^1, 2^56] range.');
         }
 
-        if (\PHP_VERSION_ID >= 80300) {
-            return new static((new Randomizer())->getBytesFromString($alphabet, $length));
-        }
-
-        $ret = '';
-        while ($length > 0) {
-            $urandomLength = (int) ceil(2 * $length * $bits / 8.0);
-            $data = random_bytes($urandomLength);
-            $unpackedData = 0;
-            $unpackedBits = 0;
-            for ($i = 0; $i < $urandomLength && $length > 0; ++$i) {
-                // Unpack 8 bits
-                $unpackedData = ($unpackedData << 8) | \ord($data[$i]);
-                $unpackedBits += 8;
-
-                // While we have enough bits to select a character from the alphabet, keep
-                // consuming the random data
-                for (; $unpackedBits >= $bits && $length > 0; $unpackedBits -= $bits) {
-                    $index = ($unpackedData & ((1 << $bits) - 1));
-                    $unpackedData >>= $bits;
-                    // Unfortunately, the alphabet size is not necessarily a power of two.
-                    // Worst case, it is 2^k + 1, which means we need (k+1) bits and we
-                    // have around a 50% chance of missing as k gets larger
-                    if ($index < $alphabetSize) {
-                        $ret .= $alphabet[$index];
-                        --$length;
-                    }
-                }
-            }
-        }
-
-        return new static($ret);
+        return new static((new Randomizer())->getBytesFromString($alphabet, $length));
     }
 
     public function bytesAt(int $offset): array
